Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented May 13, 2016

Due to unrelated meaning of Otto in some languages I've been forced to change the theme name. Starting from now it is Boxy! It's short, memorable and inspired by gift boxes.

@ghost
Copy link
Author

ghost commented May 23, 2016

Also I already informed users about renaming and breaking changes caused by it.

@michaelblyons
Copy link
Contributor

To the best of my understanding, this passes all the relevant tests of the Review Guidelines for a package change:

  • Old url redirects to the new one.
  • Has "Previous Names" in the new package definition.
  • Additionally, there is information about the change in the ReadMe and in the release notes of the existing package.

@ghost
Copy link
Author

ghost commented May 29, 2016

@FichteFoll, sorry for the ping, but I think you skipped this pr, because #5499 & #5501 were closed. Many users are waiting for it, especially newcomers from Best Sublime Text 3 Themes of 2015 and 2016. I'll push 2.0.0 tag, right after closing this pr.

@FichteFoll
Copy link
Collaborator

FichteFoll commented May 30, 2016

Yes, it appears I skipped this package because your comment 7 days ago disrupted my usual workflow, which is based on github.com/notifications and crawling that from latest update to newest. It seems that you made the comment shortly before I reviewed a larger batch of packages, thus causing the PR to be moved to the beginning of the queue rather than the end where it should have been.

Sorry for that.

@FichteFoll FichteFoll merged commit 01b4a25 into wbond:master May 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants