Skip to content

Conversation

@evandrocoan
Copy link
Contributor

Initially I was adding all my packages to the across the files, then I realized is easier just add them into one place, so I can easy know and manage what I have added to package control.

@FichteFoll
Copy link
Collaborator

FichteFoll commented Nov 2, 2017

You only removed 3 packages directly, so I assume this adds a lot of packages to the default channel that I need to review, correct?

meh

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: ERROR

Results help

Repositories added:
  - https://raw.githubusercontent.com/evandrocoan/SublimeStudioChannel/master/packages_and_dependencies.json

Processing repository "https://raw.githubusercontent.com/evandrocoan/SublimeStudioChannel/master/packages_and_dependencies.json"
  - ERROR: Unable to parse JSON

Packages removed:
  - Amxx Pawn
  - Notepad++ Color Scheme
  - amxmodx

@evandrocoan
Copy link
Contributor Author

Yes, I put everything into one file, so I can easily find them all at one place.

I tried to fix the parsing error with evandrocoan/StudioChannel@3516654, how to trigger the bot to recheck it if it is correct now?

@FichteFoll
Copy link
Collaborator

I tried re-triggering the review but only get 500 replies from the server currently.

I'm gonna hold off reviewing all these for a while because it will be a lot of work and I'd rather finish reviewing all the other PRs from different people first. I hope you understand.

@FichteFoll
Copy link
Collaborator

FichteFoll commented Dec 27, 2017

Sorry I didn't get around to reviewing these earlier btw, but it was just too much to handle back then and even now. I haven't looked into your other PR because I might miss it during the next review pass then.

@evandrocoan
Copy link
Contributor Author

I cancelled this because it seems too much work for reviewing at once, then I will create pull requests one by one over time, so it is more simple to review.

By now I send the one which is troubling me most:

  1. Fixes latest version breaks syntax highlighting #6814 Fixes latest version breaks syntax highlighting
			"releases": [
				{
					"sublime_text": ">3144",
					"tags": true
				},
				{
					"sublime_text": "<=3144",
					"tags": "build3144support-"
				}
			]

Without merging this pull request, I cannot push the next version tag 2.0.0 without breaking the syntax for the stable version 3143. Also, anyone which installs it using build 3145 or superior will get everything messy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants