-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Added my packages to channel.json with others #6690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
You only removed 3 packages directly, so I assume this adds a lot of packages to the default channel that I need to review, correct? meh |
packagecontrol-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: ERROR
Repositories added:
- https://raw.githubusercontent.com/evandrocoan/SublimeStudioChannel/master/packages_and_dependencies.json
Processing repository "https://raw.githubusercontent.com/evandrocoan/SublimeStudioChannel/master/packages_and_dependencies.json"
- ERROR: Unable to parse JSON
Packages removed:
- Amxx Pawn
- Notepad++ Color Scheme
- amxmodx
|
Yes, I put everything into one file, so I can easily find them all at one place. I tried to fix the parsing error with evandrocoan/StudioChannel@3516654, how to trigger the bot to recheck it if it is correct now? |
|
I tried re-triggering the review but only get 500 replies from the server currently. I'm gonna hold off reviewing all these for a while because it will be a lot of work and I'd rather finish reviewing all the other PRs from different people first. I hope you understand. |
|
Sorry I didn't get around to reviewing these earlier btw, but it was just too much to handle back then and even now. I haven't looked into your other PR because I might miss it during the next review pass then. |
|
I cancelled this because it seems too much work for reviewing at once, then I will create pull requests one by one over time, so it is more simple to review. By now I send the one which is troubling me most:
Without merging this pull request, I cannot push the next version tag 2.0.0 without breaking the syntax for the stable version 3143. Also, anyone which installs it using build 3145 or superior will get everything messy. |
Initially I was adding all my packages to the across the files, then I realized is easier just add them into one place, so I can easy know and manage what I have added to package control.