Skip to content

Conversation

@evandrocoan
Copy link
Contributor

Package: https://github.com/evandrocoan/FixCommandPalette

Force the Sublime Text command palette to remember the input text,
even after closing it after pressing the escape key, fixing the issue:

Also forces the command palette to make the initial text selected, fixing the regression created on
the Sublime Text build 3156:

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: WARNING

Repo link: FixCommandPalette
Results help

Packages added:
  - FixCommandPalette

Processing package "FixCommandPalette"
  - WARNING: The binding ['escape'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['ctrl+shift+p'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap

@evandrocoan
Copy link
Contributor Author

Processing package "FixCommandPalette"
  - WARNING: The binding ['escape'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['ctrl+shift+p'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap

I need to override those to control the command palette closing and opening and be able to select and save the inputs.

@FichteFoll
Copy link
Collaborator

I think you might be able to implement that with on_(post_)window_command hooks too, but you'd have to do some experimentation.

@FichteFoll
Copy link
Collaborator

I personally find the package name too general. Considering that sublimehq/sublime_text#2083 has been fixed in the latest build, maybe you can come up with a name that better describes what it does regarding the other issue? E.g. "RememberCommandPaletteInput".

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: WARNING

Repo link: RememberCommandPaletteInput
Results help

Packages added:
  - RememberCommandPaletteInput

Processing package "RememberCommandPaletteInput"
  - WARNING: The binding ['escape'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['ctrl+shift+p'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap

evandrocoan added a commit to evandrocoan/StudioChannel that referenced this pull request Feb 20, 2018
Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: WARNING

Repo link: RememberCommandPaletteInput
Results help

Packages added:
  - RememberCommandPaletteInput

Processing package "RememberCommandPaletteInput"
  - WARNING: The binding ['escape'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['ctrl+shift+p'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap

evandrocoan added a commit to evandrocoan/ITE that referenced this pull request Feb 20, 2018
@evandrocoan
Copy link
Contributor Author

I cannot, they are not logged by Sublime Text:

  1. The commands show_overlay, hide_overlay and countless others are not logged by on_window_command sublimehq/sublime_text#2198 The command show_overlay and hide_overlay is not logged by on_window_command

@FichteFoll FichteFoll merged commit ce61c44 into wbond:master Feb 20, 2018
@evandrocoan evandrocoan deleted the fix_command_palette branch February 20, 2018 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants