Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Octave Support #7517

Merged
merged 1 commit into from Jun 23, 2019

Conversation

Projects
None yet
3 participants
@apjanke
Copy link
Contributor

commented Mar 20, 2019

This package provides syntax definitions, indent settings, and snippets for GNU Octave.

There's an existing GNU Octave Completions package, but that only does completions; this package has additional functionality.

@packagecontrol-bot
Copy link
Collaborator

left a comment

Automated testing result: SUCCESS

Repo link: Octave Support

Packages added:
  - Octave Support

Processing package "Octave Support"
  - All checks passed

@apjanke apjanke referenced this pull request Mar 20, 2019

Open

Get into Package Control #2

@apjanke apjanke force-pushed the apjanke:add-Octave-Support branch from 62bda4c to 61d1276 Mar 20, 2019

@apjanke apjanke force-pushed the apjanke:add-Octave-Support branch from 61d1276 to 6e34f47 Mar 20, 2019

@packagecontrol-bot
Copy link
Collaborator

left a comment

Automated testing result: SUCCESS

Repo link: OctaveSupport

Packages added:
  - OctaveSupport

Processing package "OctaveSupport"
  - All checks passed
@packagecontrol-bot
Copy link
Collaborator

left a comment

Automated testing result: SUCCESS

Repo link: OctaveSupport

Packages added:
  - OctaveSupport

Processing package "OctaveSupport"
  - All checks passed
@Thom1729

This comment has been minimized.

Copy link
Collaborator

commented Mar 23, 2019

Would it make sense to add new functionality to the existing package rather than creating a new package?

@apjanke

This comment has been minimized.

Copy link
Contributor Author

commented Mar 23, 2019

Yes. It's just a question of whether the author of the existing package is willing to accept all these changes. I'll ask them.

@apjanke

This comment has been minimized.

Copy link
Contributor Author

commented Mar 23, 2019

Asked the existing package's author: tushortz/GNU-Octave-Completions#3

@Thom1729 Thom1729 merged commit 2129e25 into wbond:master Jun 23, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.