Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added codeigniter 4 snippets support #7845

Merged
merged 2 commits into from Mar 17, 2020
Merged

Added codeigniter 4 snippets support #7845

merged 2 commits into from Mar 17, 2020

Conversation

@mpmont
Copy link
Contributor

mpmont commented Mar 3, 2020

No description provided.

Copy link
Collaborator

packagecontrol-bot left a comment

Automated testing result: SUCCESS

Repo link: CodeIgniter 4 Snippets

Packages added:
  - CodeIgniter 4 Snippets

Processing package "CodeIgniter 4 Snippets"
  - All checks passed
@mpmont

This comment has been minimized.

Copy link
Contributor Author

mpmont commented Mar 4, 2020

Hi there, from what I understand this gave an error because of my package name. But I can't find a package with the same name. Can this be from a old pull request I had with the same name?

@FichteFoll

This comment has been minimized.

Copy link
Collaborator

FichteFoll commented Mar 10, 2020

Hi there, from what I understand this gave an error because of my package name.

No, there was and still is an error because you didn't insert your package in the right location. It should be here. Please don't create a new PR when addressing this and instead push new commits to your master branch (which you inconveniently opened this PR from).

Copy link
Collaborator

packagecontrol-bot left a comment

Automated testing result: SUCCESS

Repo link: CodeIgniter 4 Snippets

Packages added:
  - CodeIgniter 4 Snippets

Processing package "CodeIgniter 4 Snippets"
  - All checks passed
@mpmont

This comment has been minimized.

Copy link
Contributor Author

mpmont commented Mar 11, 2020

Hi there, thank you for you feedback. Sorry for that second pull request. I think everything is good now.

@FichteFoll

This comment has been minimized.

Copy link
Collaborator

FichteFoll commented Mar 17, 2020

Note that you'll have to push a new tag with a higher version in order to make a new release. PC won't check your master branch.

@FichteFoll FichteFoll merged commit ce45b73 into wbond:master Mar 17, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mpmont

This comment has been minimized.

Copy link
Contributor Author

mpmont commented Mar 19, 2020

@FichteFoll So every time there's a new version I need to create the new tag and create a new pull request with the respective tag right?

@mpmont

This comment has been minimized.

Copy link
Contributor Author

mpmont commented Mar 19, 2020

Oh got it I just need to make the new tag in my repo and the package will get the latest one. ok.

@FichteFoll

This comment has been minimized.

Copy link
Collaborator

FichteFoll commented Mar 22, 2020

Correct, you create a new tag for your repo and PC will detect the new version within a an hour Usually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.