Skip to content

Conversation

@haferburg
Copy link

No description provided.

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: Inline Images

Packages added:
  - Inline Images

Processing package "Inline Images"
  - All checks passed

@haferburg
Copy link
Author

It's been 10 weeks, and the PR hasn't been merged. Is there a problem with the PR or the package? Did I do something wrong?

@UltraInstinct05
Copy link
Contributor

Here are a couple of areas where you can improve.

  1. The test directory mainly seems to have files & images that are used for testing purposes and not needed by the package in anyway. You can use .gitattributes's export-ignore flag to prevent shipping such files to the end users.
  2. https://github.com/haferburg/Sublime-Inline-Images/blob/main/Main.sublime-menu#L18-L27 Please don't use the open_file command to add 2 different menu items for settings. When it comes to settings, the best experience comes when they are viewed side by side. Consider using the edit_settings command instead.
"children": [
    {
        "caption": "Settings",
        "command": "edit_settings",
        "args": { "base_file": "${packages}/Inline Images/Inline Images.sublime-settings" },
    },
]
  1. https://github.com/haferburg/Sublime-Inline-Images/blob/main/messages.json Please don't use the README as an install message. Markdown is not a suitable way of showing package install/update messages. Consider using a simple plain text file instead. References: https://packagecontrol.io/docs/messaging

Haven't gone into great detail about the plugin itself, but otherwise looks okay.

@braver
Copy link
Collaborator

braver commented Dec 4, 2021

Your README itself links to similar packages, but you don't explain why we need to add yours. We try to prevent duplication.

@braver braver added duplicate feedback provided The changes and package have been seen by a reviewer labels Dec 4, 2021
@haferburg haferburg closed this Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feedback provided The changes and package have been seen by a reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants