Skip to content

Re-adds Urtext #9087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 12 commits into from
Closed

Re-adds Urtext #9087

wants to merge 12 commits into from

Conversation

@nbeversl
Copy link
Contributor

@nbeversl nbeversl commented Apr 13, 2025 •
edited
Loading

  • I'm the package's author and/or maintainer.
  • I have have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • If my package is a syntax it doesn't also add a color scheme. ***
  • If my package is a syntax it is named after the language it supports (without suffixes like "syntax" or "highlighting").
  • I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

My package is ...

There are no packages like it in Package Control.

My package is similar to ... However it should still be added because ...

@nbeversl
Copy link
Contributor Author

nbeversl commented Apr 15, 2025 •
edited
Loading

pursuant to https://forum.sublimetext.com/t/using-sublime-text-as-a-frontend-for-a-note-taking-app/74770/16?u=nbeversl

Checkbox items have been covered copiously in previous PRs.

packagecontrol-bot
packagecontrol-bot requested changes Apr 15, 2025
View reviewed changes
Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: ERROR

Repo link: Urtext
Results help

Packages added:
  - Urtext

Processing package "Urtext"
  - ERROR: The binding ['ctrl+shift+8'] unconditionally overrides a default binding
    - File: Default.sublime-keymap
  - ERROR: The binding ['ctrl+shift+z'] unconditionally overrides a default binding
    - File: Default.sublime-keymap
  - ERROR: The binding ['ctrl+shift+left'] unconditionally overrides a default binding
    - File: Default.sublime-keymap
  - ERROR: The binding ['ctrl+shift+6'] unconditionally overrides a default binding
    - File: Default.sublime-keymap
  - ERROR: The binding ['ctrl+shift+j'] unconditionally overrides a default binding
    - File: Default.sublime-keymap
  - ERROR: The binding ['ctrl+shift+m'] unconditionally overrides a default binding
    - File: Default.sublime-keymap
  - ERROR: The binding ['ctrl+shift+right'] unconditionally overrides a default binding
    - File: Default.sublime-keymap
  - ERROR: The binding ['ctrl+shift+f'] unconditionally overrides a default binding
    - File: Default.sublime-keymap
  - ERROR: The binding ['ctrl+shift+j'] unconditionally overrides a default binding
    - File: Default.sublime-keymap
  - ERROR: The binding ['ctrl+shift+t'] unconditionally overrides a default binding
    - File: Default.sublime-keymap
  - ERROR: The binding ['ctrl+shift+l'] unconditionally overrides a default binding
    - File: Default.sublime-keymap
  - ERROR: The binding ['ctrl+shift+n'] unconditionally overrides a default binding
    - File: Default.sublime-keymap
  - ERROR: The binding ['ctrl+shift+e'] unconditionally overrides a default binding
    - File: Default.sublime-keymap
  - ERROR: The binding ['ctrl+shift+h'] unconditionally overrides a default binding
    - File: Default.sublime-keymap
  - ERROR: The binding ['ctrl+shift+/'] unconditionally overrides a default binding
    - File: Default.sublime-keymap
  - ERROR: The binding ['ctrl+shift+b'] unconditionally overrides a default binding
    - File: Default.sublime-keymap
  - ERROR: The binding ['ctrl+shift+i'] unconditionally overrides a default binding
    - File: Default.sublime-keymap
  - ERROR: The binding ['ctrl+shift+s'] unconditionally overrides a default binding
    - File: Default.sublime-keymap
  - ERROR: The binding ['ctrl+shift+9'] unconditionally overrides a default binding
    - File: Default.sublime-keymap
  - ERROR: The binding ['ctrl+shift+r'] unconditionally overrides a default binding
    - File: Default.sublime-keymap
  - ERROR: The binding ['ctrl+shift+['] unconditionally overrides a default binding
    - File: Default.sublime-keymap
  - ERROR: The binding ['ctrl+alt+shift+right'] unconditionally overrides a default binding
    - File: Default.sublime-keymap
  - ERROR: The binding ['ctrl+alt+shift+left'] unconditionally overrides a default binding
    - File: Default.sublime-keymap
  - WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    - File: sublime_urtext.sublime-syntax
  - WARNING: The package does not contain a top-level LICENSE file. A license helps users to contribute to the package.
  - WARNING: '.no-sublime-package' is defined. Please verify that it is *really* necessary
  - WARNING: It is not advised to specify mousemaps because of how limited the configuration options are. Instead, suggest the user to add specific bindings to their User package.
    - File: Default.sublime-mousemap

@nbeversl nbeversl closed this Apr 15, 2025
@nbeversl nbeversl reopened this Apr 15, 2025
packagecontrol-bot
packagecontrol-bot requested changes Apr 15, 2025
View reviewed changes
Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: ERROR

Repo link: Urtext
Results help

Packages added:
  - Urtext

Processing package "Urtext"
  - ERROR: The binding ['ctrl+shift+z'] unconditionally overrides a default binding
    - File: Default.sublime-keymap
  - ERROR: The binding ['ctrl+shift+e'] unconditionally overrides a default binding
    - File: Default.sublime-keymap
  - WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    - File: sublime_urtext.sublime-syntax
  - WARNING: The binding ['ctrl+shift+8'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['ctrl+shift+left'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['ctrl+shift+j'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['ctrl+shift+m'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['ctrl+shift+right'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['ctrl+shift+f'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['ctrl+shift+j'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['ctrl+shift+t'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['ctrl+shift+l'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['ctrl+shift+n'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['ctrl+shift+h'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['ctrl+shift+/'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['ctrl+shift+b'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['ctrl+shift+i'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['ctrl+shift+s'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['ctrl+shift+9'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['ctrl+shift+r'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['ctrl+shift+['] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['ctrl+alt+shift+right'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['ctrl+alt+shift+left'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: It is not advised to specify mousemaps because of how limited the configuration options are. Instead, suggest the user to add specific bindings to their User package.
    - File: Default.sublime-mousemap
  - WARNING: '.no-sublime-package' is defined. Please verify that it is *really* necessary
  - WARNING: The package does not contain a top-level LICENSE file. A license helps users to contribute to the package.

@nbeversl
Copy link
Contributor Author

nbeversl commented Apr 15, 2025 •
edited
Loading

Release https://github.com/nbeversl/urtext_sublime/releases/tag/1.9.48 mitigates the issue of global keybindings.
#9087 (review)

packagecontrol-bot
packagecontrol-bot requested changes Apr 16, 2025
View reviewed changes
Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: ERROR

Repo link: Urtext
Results help

Packages added:
  - Urtext

Processing package "Urtext"
  - ERROR: The binding ['ctrl+shift+z'] unconditionally overrides a default binding
    - File: Default.sublime-keymap
  - ERROR: The binding ['ctrl+shift+e'] unconditionally overrides a default binding
    - File: Default.sublime-keymap
  - WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    - File: sublime_urtext.sublime-syntax
  - WARNING: The binding ['ctrl+shift+8'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['ctrl+shift+left'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['ctrl+shift+j'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['ctrl+shift+m'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['ctrl+shift+right'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['ctrl+shift+f'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['ctrl+shift+j'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['ctrl+shift+t'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['ctrl+shift+l'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['ctrl+shift+n'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['ctrl+shift+h'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['ctrl+shift+/'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['ctrl+shift+b'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['ctrl+shift+i'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['ctrl+shift+s'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['ctrl+shift+9'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['ctrl+shift+r'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['ctrl+shift+['] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['ctrl+alt+shift+right'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['ctrl+alt+shift+left'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: '.no-sublime-package' is defined. Please verify that it is *really* necessary
  - WARNING: The package does not contain a top-level LICENSE file. A license helps users to contribute to the package.
  - WARNING: It is not advised to specify mousemaps because of how limited the configuration options are. Instead, suggest the user to add specific bindings to their User package.
    - File: Default.sublime-mousemap

packagecontrol-bot
packagecontrol-bot requested changes Apr 16, 2025
View reviewed changes
Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: ERROR

Repo link: Urtext
Results help

Packages added:
  - Urtext

Processing package "Urtext"
  - ERROR: Unhandled exception in 'check' routine
    - Exception: Expecting value: line 484 column 1 (char 483)
  - ERROR: Invalid JSON (with comments)
    - File: Default.sublime-keymap
    - Exception: Expecting value: line 484 column 1 (char 483)
  - WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    - File: sublime_urtext.sublime-syntax
  - WARNING: It is not advised to specify mousemaps because of how limited the configuration options are. Instead, suggest the user to add specific bindings to their User package.
    - File: Default.sublime-mousemap
  - WARNING: The package does not contain a top-level LICENSE file. A license helps users to contribute to the package.
  - WARNING: '.no-sublime-package' is defined. Please verify that it is *really* necessary

@nbeversl
Copy link
Contributor Author

nbeversl commented Apr 16, 2025

Can you please explain this:

  • ERROR: Unhandled exception in 'check' routine
    • Exception: Expecting value: line 484 column 1 (char 483)
    • ERROR: Invalid JSON (with comments)
      • File: Default.sublime-keymap
      • Exception: Expecting value: line 484 column 1 (char 483)

Keybindings are commented out as requested.

I'm hoping we can get this one merged quickly now, see https://forum.sublimetext.com/t/using-sublime-text-as-a-frontend-for-a-note-taking-app/74770/16?u=nbeversl

@nbeversl nbeversl closed this Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@packagecontrol-bot packagecontrol-bot packagecontrol-bot requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nbeversl @packagecontrol-bot