Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI and fix build #11

Merged
merged 7 commits into from Feb 23, 2022
Merged

Update CI and fix build #11

merged 7 commits into from Feb 23, 2022

Conversation

zmughal
Copy link
Collaborator

@zmughal zmughal commented Feb 12, 2022

Some systems have separate packages for the PCRE2 binaries and the
development headers (e.g., Debian has `pcre2-utils` and `libpcre2-dev`
respectively). Only a share install can guarantee that the binaries are
available.
@zmughal
Copy link
Collaborator Author

zmughal commented Feb 12, 2022

@wbraswell
Copy link
Owner

@zmughal
Why are we showing "All checks have failed, 1 failing check, AppVeyor build failed" ?

@zmughal
Copy link
Collaborator Author

zmughal commented Feb 23, 2022

@wbraswell, seems like AppVeyor did not install Strawberry Perl. I would recommend using Chocolatey: https://dev.to/yukikimoto/install-strawberry-perl-using-chocolatey-on-windows-4if3

I used to use AppVeyor myself and this was how I would set it up: https://github.com/zmughal-CPAN/p5-Alien-ZMQ-latest/blob/ff789fc7e317914e5f89b65d3c2bc95ca361e094/appveyor.yml

@zmughal
Copy link
Collaborator Author

zmughal commented Feb 23, 2022

As discussed, fixed the AppVeyor build (now tests with 32- and 64-bit Strawberry Perl).

@wbraswell
Copy link
Owner

@zmughal
It looks good so far!
For the record, can you please elaborate on the purpose for the "Rewrite postamble" commit?

@zmughal
Copy link
Collaborator Author

zmughal commented Feb 23, 2022

I wanted to simplify the build by removing what wasn't necessary. The build still passes.

@wbraswell wbraswell merged commit 65a3392 into wbraswell:master Feb 23, 2022
@zmughal zmughal deleted the ci branch February 23, 2022 17:07
@zmughal
Copy link
Collaborator Author

zmughal commented Mar 3, 2022

@wbraswell, this can now be released, correct?

@wbraswell
Copy link
Owner

@zmughal
You are wanting to release to CPAN, I assume?

@zmughal
Copy link
Collaborator Author

zmughal commented Mar 7, 2022

@wbraswell, yes, please! Released to CPAN. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PCRE2 is now hosted on GitHub
2 participants