feat(api): extend ingresscreator role to allow for job management #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m90
force-pushed
the
fr/extend-ingresscreator-role
branch
from
d91b78e to
79e1084
Compare
m90
force-pushed
the
fr/extend-ingresscreator-role
branch
from
04c5fe5 to
33e7d81
Compare
deer-wmde
approved these changes
Jun 1, 2023
Contributor
deer-wmde
left a comment
deer-wmde
left a comment
There was a problem hiding this comment.
Can confirm this worked locally for me! details: https://phabricator.wikimedia.org/T330389#8895083
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket https://phabricator.wikimedia.org/T330389
I went for augmenting the existing role as I currently cannot see any benefits from creating a second role and making it accessible to api. If api can access the role in code, malicious/non-functioning code could also just pick any role.