Skip to content

Swap out Wikibase for a version that includes submodules#328

Merged
AndrewKostka merged 1 commit into
mainfrom
fix-missing-wikibase-submodules
Mar 21, 2023
Merged

Swap out Wikibase for a version that includes submodules#328
AndrewKostka merged 1 commit into
mainfrom
fix-missing-wikibase-submodules

Conversation

@AndrewKostka

Copy link
Copy Markdown
Contributor

No description provided.

@deer-wmde

Copy link
Copy Markdown
Contributor

the files are there now, yay 🎉

for some reason I still get the same console error log in the frontend when testing this locally with skaffold though, even though the files are definitely deployed 🤔 I think I might just do something wrong there

@AndrewKostka

Copy link
Copy Markdown
Contributor Author

for some reason I still get the same console error log in the frontend when testing this locally with skaffold though, even though the files are definitely deployed 🤔 I think I might just do something wrong there

@deer-wmde this might be caused by ResourceLoader's caching. Could you try bypassing the cache when reloading the page or using a private window?

@rosalieper

Copy link
Copy Markdown
Contributor

Sorry to ask but I am missing the reason behind this. what will adding the sub modules fix or add, that we want?

@AndrewKostka AndrewKostka merged commit 2b28375 into main Mar 21, 2023
@AndrewKostka AndrewKostka deleted the fix-missing-wikibase-submodules branch March 21, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants