Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #22 - Allow install with Python 2.7 #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

clach04
Copy link

@clach04 clach04 commented Jul 28, 2023

No description provided.

@clach04
Copy link
Author

clach04 commented Jul 28, 2023

Pip install works for me with Python 2.10.18 64-bit Under Windows.

All tests pass bar one, which is relying on a website that no longer exists:

(py27venv) C:\code\py\pypub\pypub_wcember_original_upstream>python pypub/unit_tests_chapter.py
....
----------------------------------------------------------------------
Ran 4 tests in 0.326s

OK

(py27venv) C:\code\py\pypub\pypub_wcember_original_upstream>python pypub/unit_tests_clean.py
......
----------------------------------------------------------------------
Ran 6 tests in 0.010s

OK

(py27venv) C:\code\py\pypub\pypub_wcember_original_upstream>python pypub/unit_tests_epub.py
....
----------------------------------------------------------------------
Ran 4 tests in 60.727s

OK

(py27venv) C:\code\py\pypub\pypub_wcember_original_upstream>python pypub/unit_tests_image.py
..E.
======================================================================
ERROR: test_save_image (__main__.ChapterTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "pypub/unit_tests_image.py", line 24, in test_save_image
    'test image ' + str(index)),
  File "C:\code\py\pypub\pypub_wcember_original_upstream\pypub\chapter.py", line 82, in save_image
    raise ImageErrorException(image_url)
ImageErrorException: Error downloading image from http://bothsides.wpengine.netdna-cdn.com/wp-content/uploads/2015/11/bothsides1.jpg

----------------------------------------------------------------------
Ran 4 tests in 1.829s

FAILED (errors=1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant