New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAN bound? #5

Open
sckott opened this Issue Aug 7, 2015 · 18 comments

Comments

Projects
None yet
6 participants
@sckott
Collaborator

sckott commented Aug 7, 2015

@wch any plans to send this to CRAN? I was thinking of getting analogsea to CRAN soon. We don't use harbor yet, but we could more easily if on CRAN

@wch

This comment has been minimized.

Show comment
Hide comment
@wch

wch Aug 7, 2015

Owner

No plans to anytime soon... If you want to clean it up, please feel free to
do so. :)

On Fri, Aug 7, 2015 at 2:54 PM, Scott Chamberlain notifications@github.com
wrote:

@wch https://github.com/wch any plans to send this to CRAN? I was
thinking of getting analogsea to CRAN soon. We don't use harbor yet, but
we could more easily if on CRAN


Reply to this email directly or view it on GitHub
#5.

Owner

wch commented Aug 7, 2015

No plans to anytime soon... If you want to clean it up, please feel free to
do so. :)

On Fri, Aug 7, 2015 at 2:54 PM, Scott Chamberlain notifications@github.com
wrote:

@wch https://github.com/wch any plans to send this to CRAN? I was
thinking of getting analogsea to CRAN soon. We don't use harbor yet, but
we could more easily if on CRAN


Reply to this email directly or view it on GitHub
#5.

@sckott

This comment has been minimized.

Show comment
Hide comment
@sckott

sckott Aug 7, 2015

Collaborator

ok, I'm just getting back into analogsea work, so I'll go over the harbor related stuff soon

Collaborator

sckott commented Aug 7, 2015

ok, I'm just getting back into analogsea work, so I'll go over the harbor related stuff soon

@MarkEdmondson1234

This comment has been minimized.

Show comment
Hide comment
@MarkEdmondson1234

MarkEdmondson1234 Oct 6, 2016

Contributor

If it just needs updates to the documentation so it passes CRAN checks, I can help with that - it now passes a CRAN check in this pull #7, probably a bit more to do

Contributor

MarkEdmondson1234 commented Oct 6, 2016

If it just needs updates to the documentation so it passes CRAN checks, I can help with that - it now passes a CRAN check in this pull #7, probably a bit more to do

@hrbrmstr

This comment has been minimized.

Show comment
Hide comment
@hrbrmstr

hrbrmstr Feb 6, 2017

Collaborator

Piling on here to see how I might help get this into CRAN and to suggest that it doesn't need to support boot2docker anymore with Docker being a first class citizen on macOS & Windows now. I freely admit this is selfish since I'm using it in https://github.com/hrbrmstr/splashr to install, start & stop a Splash server, but in doing so realized that this could be an excellent model for other middleware engines (like Splash, Selenium, phantomjs, etc) to keep those things separate from the local operating system and abstract the complexity away from R users.

So, I'm here to help and willing to mod/clean, but don't want to stop over any other work in the other two forks, so just lemme know what I can do to help get this puppy in CRAN.

I can also just ask permission to copy-and-credit-at-will from it to make splashr work, but this would be a wicked useful pkg in the wild IMO.

Collaborator

hrbrmstr commented Feb 6, 2017

Piling on here to see how I might help get this into CRAN and to suggest that it doesn't need to support boot2docker anymore with Docker being a first class citizen on macOS & Windows now. I freely admit this is selfish since I'm using it in https://github.com/hrbrmstr/splashr to install, start & stop a Splash server, but in doing so realized that this could be an excellent model for other middleware engines (like Splash, Selenium, phantomjs, etc) to keep those things separate from the local operating system and abstract the complexity away from R users.

So, I'm here to help and willing to mod/clean, but don't want to stop over any other work in the other two forks, so just lemme know what I can do to help get this puppy in CRAN.

I can also just ask permission to copy-and-credit-at-will from it to make splashr work, but this would be a wicked useful pkg in the wild IMO.

@MarkEdmondson1234

This comment has been minimized.

Show comment
Hide comment
@MarkEdmondson1234

MarkEdmondson1234 Feb 6, 2017

Contributor

I did the copy-and-credit-at-will approach for my CRAN submission, maybe added an extra function or two but would prefer pulling that out into this package on CRAN

Contributor

MarkEdmondson1234 commented Feb 6, 2017

I did the copy-and-credit-at-will approach for my CRAN submission, maybe added an extra function or two but would prefer pulling that out into this package on CRAN

@wch

This comment has been minimized.

Show comment
Hide comment
@wch

wch Feb 6, 2017

Owner

I don't plan on spending time on harbor in the foreseeable future, so if you guys want to become admins on the project and do the release/maintenance, let me know.

Owner

wch commented Feb 6, 2017

I don't plan on spending time on harbor in the foreseeable future, so if you guys want to become admins on the project and do the release/maintenance, let me know.

@hrbrmstr

This comment has been minimized.

Show comment
Hide comment
@hrbrmstr

hrbrmstr Feb 6, 2017

Collaborator

yes pls :-)

Collaborator

hrbrmstr commented Feb 6, 2017

yes pls :-)

@wch

This comment has been minimized.

Show comment
Hide comment
@wch

wch Feb 6, 2017

Owner

@hrbrmstr Done. Before you release, please feel free to make yourself the maintainer (AKA cre) in the DESCRIPTION file.

Owner

wch commented Feb 6, 2017

@hrbrmstr Done. Before you release, please feel free to make yourself the maintainer (AKA cre) in the DESCRIPTION file.

@hrbrmstr

This comment has been minimized.

Show comment
Hide comment
@hrbrmstr

hrbrmstr Feb 7, 2017

Collaborator

Cool. @sckott @MarkEdmondson1234 I'm prbly going to be pushing "breaking" changes soon (next 24-48 hours). I'm switching to sys and adding some more general Docker mgmt commands. It may not impact anything y'all are doing but wanted to make sure you both knew that. There are a handful of folks watching and Rich has a somewhat active fork, so hopefully anyone else "depending" on this will see what's going on.

A big change is removing "boot2docker" support since Linux, Windows and macOS all work the same way now. Unless there's a YUGE objection to that.

Collaborator

hrbrmstr commented Feb 7, 2017

Cool. @sckott @MarkEdmondson1234 I'm prbly going to be pushing "breaking" changes soon (next 24-48 hours). I'm switching to sys and adding some more general Docker mgmt commands. It may not impact anything y'all are doing but wanted to make sure you both knew that. There are a handful of folks watching and Rich has a somewhat active fork, so hopefully anyone else "depending" on this will see what's going on.

A big change is removing "boot2docker" support since Linux, Windows and macOS all work the same way now. Unless there's a YUGE objection to that.

@sckott

This comment has been minimized.

Show comment
Hide comment
@sckott

sckott Feb 7, 2017

Collaborator

sounds good - was going to move to using this in analogsea - but never got around to this, so happy someone is doing it

Collaborator

sckott commented Feb 7, 2017

sounds good - was going to move to using this in analogsea - but never got around to this, so happy someone is doing it

@cboettig

This comment has been minimized.

Show comment
Hide comment
@cboettig

cboettig Sep 5, 2017

Any updates to sending this onto CRAN? It would work nicely I think with my little wrapper to docker-machine (https://github.com/cboettig/dockermachine) to allow R users to script deploys of long-running jobs to the cloud without having to leave the R interface

cboettig commented Sep 5, 2017

Any updates to sending this onto CRAN? It would work nicely I think with my little wrapper to docker-machine (https://github.com/cboettig/dockermachine) to allow R users to script deploys of long-running jobs to the cloud without having to leave the R interface

@sckott

This comment has been minimized.

Show comment
Hide comment
@sckott

sckott Sep 5, 2017

Collaborator

dont know, thoughts @hrbrmstr ?

Collaborator

sckott commented Sep 5, 2017

dont know, thoughts @hrbrmstr ?

@hrbrmstr

This comment has been minimized.

Show comment
Hide comment
@hrbrmstr

hrbrmstr Sep 5, 2017

Collaborator
Collaborator

hrbrmstr commented Sep 5, 2017

@nuest nuest referenced this issue Dec 12, 2017

Open

Release on CRAN #68

0 of 5 tasks complete
@nuest

This comment has been minimized.

Show comment
Hide comment
@nuest

nuest Jan 3, 2018

👍 on initial submission for Linux/macOS, though if Windows tests are a blocker, I'd get my hands on a Windows 10 machine and run tests.

nuest commented Jan 3, 2018

👍 on initial submission for Linux/macOS, though if Windows tests are a blocker, I'd get my hands on a Windows 10 machine and run tests.

@nuest

This comment has been minimized.

Show comment
Hide comment
@nuest

nuest Jan 5, 2018

The latest Appveyor has Docker support and I was able to let harbor tests run:

https://ci.appveyor.com/project/nuest/harbor/build/1.0.3

image

The tests all run, see "artifacts" > file harbor.Rcheck\tests\testthat.Rout:

> library(testthat)
> library(harbor)
> 
> test_check("harbor")
== testthat results  ===========================================================
OK: 3 SKIPPED: 0 FAILED: 0
> 

I was also able to fix warnings and tests complete for different R versions:

https://ci.appveyor.com/project/nuest/harbor/build/1.0.5

image


So basic features work on Windows and can be tested on Appveyor with these changes: https://github.com/wch/harbor/compare/master...nuest:appveyor?expand=1

I'd be happy to contribute some more tests following the todo list by @hrbrmstr and create a PR.

  • Before CRAN, the status badges should be updated to the main repo.

nuest commented Jan 5, 2018

The latest Appveyor has Docker support and I was able to let harbor tests run:

https://ci.appveyor.com/project/nuest/harbor/build/1.0.3

image

The tests all run, see "artifacts" > file harbor.Rcheck\tests\testthat.Rout:

> library(testthat)
> library(harbor)
> 
> test_check("harbor")
== testthat results  ===========================================================
OK: 3 SKIPPED: 0 FAILED: 0
> 

I was also able to fix warnings and tests complete for different R versions:

https://ci.appveyor.com/project/nuest/harbor/build/1.0.5

image


So basic features work on Windows and can be tested on Appveyor with these changes: https://github.com/wch/harbor/compare/master...nuest:appveyor?expand=1

I'd be happy to contribute some more tests following the todo list by @hrbrmstr and create a PR.

  • Before CRAN, the status badges should be updated to the main repo.
@nuest

This comment has been minimized.

Show comment
Hide comment
@nuest

nuest Feb 14, 2018

@hrbrmstr bump.
I'm happy to contribute what's needed.

nuest commented Feb 14, 2018

@hrbrmstr bump.
I'm happy to contribute what's needed.

@hrbrmstr

This comment has been minimized.

Show comment
Hide comment
@hrbrmstr

hrbrmstr Feb 14, 2018

Collaborator

Oh this is gd news (apologies for the late reply). Have folks seen https://github.com/richfitz/stevedore ? It does the docker API vs cmdline machinations but is pure R vs an R shim to Python.

Collaborator

hrbrmstr commented Feb 14, 2018

Oh this is gd news (apologies for the late reply). Have folks seen https://github.com/richfitz/stevedore ? It does the docker API vs cmdline machinations but is pure R vs an R shim to Python.

@nuest

This comment has been minimized.

Show comment
Hide comment
@nuest

nuest Feb 15, 2018

I did not know stevedore, thanks for the pointer. The approach using the API+Swagger is quite cool. AFAICS stevedore is pure R, but the required package httppipe needs reticulate, at least currently, for Windows support.

@hrbrmstr Do you suggest evaluating the different approaches of existing packages before going ahead with submitting harbor to CRAN?

nuest commented Feb 15, 2018

I did not know stevedore, thanks for the pointer. The approach using the API+Swagger is quite cool. AFAICS stevedore is pure R, but the required package httppipe needs reticulate, at least currently, for Windows support.

@hrbrmstr Do you suggest evaluating the different approaches of existing packages before going ahead with submitting harbor to CRAN?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment