Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImproved install phantomjs #82
Conversation
|
It would be better if |
|
@wch thanks. I'll add in a version check. |
|
@wch I've added in the version check. To do so, I've created three internal functions:
|
|
A few minor things, but otherwise it looks good. |
|
@wch ready for round 3. |
|
|
||
| if (is_phantomjs_version_latest(version) && !force) { | ||
| message('It seems that the installed version of `phantomjs` is the latest. ', | ||
| 'To reinstall the version presently installed, use `force = TRUE`.') |
wch
May 24, 2019
•
Owner
Slight correction: this won't necessarily install the presently-installed version; it will install the version specified by the version parameter. Also, getting here doesn't necessarily mean that the latest version is installed; it just means that the version is >= to version.
Slight correction: this won't necessarily install the presently-installed version; it will install the version specified by the version parameter. Also, getting here doesn't necessarily mean that the latest version is installed; it just means that the version is >= to version.
coatless
May 24, 2019
Author
Contributor
I updated the message to reflect this.
I updated the message to reflect this.
|
@wch let's try round 4? |
|
Thanks! |
This PR implements the PhantomJS installation check as described in #25 by:
is_phantomjs_installed()function that returnsTRUE/FALSEif PhantomJS is installed or not.install_phantomjs()to includeforce, which controls whether PhantomJS will be installed or not if it already is present on the user's computer.