Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upIn Linux it should be installed without failure #84
Conversation
| @@ -206,6 +206,10 @@ phantom_paths <- function() { | |||
| } else if (is_osx()) { | |||
| path <- '~/Library/Application Support' | |||
| path <- if (dir_exists(path)) file.path(path, 'PhantomJS') | |||
| } else if (is_linux()) { | |||
| path <- '~/bin' | |||
| path <- if (!dir_exists(path)) dir.create(path,recursive = TRUE) | |||
wch
Jun 25, 2019
Owner
I think this isn't the right place to create the directory -- this function simply returns a possible path for the executable to go; it should not create the path.
The suggestion in #74 seems like the right way to go.
I think this isn't the right place to create the directory -- this function simply returns a possible path for the executable to go; it should not create the path.
The suggestion in #74 seems like the right way to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
#74