From 701069e77b73d5fc15d24fb9b37e000eab908060 Mon Sep 17 00:00:00 2001 From: atomicpages Date: Sun, 9 Jun 2019 13:30:51 -0700 Subject: [PATCH] SMall fixes * Adding condition to check node version * Adding ndoe typings --- .travis.yml | 1 + package.json | 1 + src/sync-dir.ts | 13 ++++++++++--- yarn.lock | 5 +++++ 4 files changed, 17 insertions(+), 3 deletions(-) diff --git a/.travis.yml b/.travis.yml index f7e7207..86c523c 100644 --- a/.travis.yml +++ b/.travis.yml @@ -3,6 +3,7 @@ language: node_js node_js: - 8.16.0 - 10.0.0 + - 12.0.0 script: yarn ci branches: only: diff --git a/package.json b/package.json index 9adc660..b2b49c8 100644 --- a/package.json +++ b/package.json @@ -41,6 +41,7 @@ "@types/fs-extra": "^7.0.0", "@types/glob": "^5.0.30", "@types/mocha": "^2.2.40", + "@types/node": "^12.0.7", "@types/npm-packlist": "^1.1.0", "@types/yargs": "^6.6.0", "clean-ts-built": "^1.0.0", diff --git a/src/sync-dir.ts b/src/sync-dir.ts index be63ae4..beb3099 100644 --- a/src/sync-dir.ts +++ b/src/sync-dir.ts @@ -4,9 +4,16 @@ import { resolve } from 'path' import * as fs from 'fs-extra' import { getFileHash } from './copy' -// Symbol.asyncIterator polyfill for Node 8 + 9 -;(Symbol as any).asyncIterator = - Symbol.asyncIterator || Symbol('Symbol.asyncIterator') +const NODE_MAJOR_VERSION = parseInt( + (process).versions.node.split('.').shift(), + 10 +) + +if (NODE_MAJOR_VERSION >= 8 && NODE_MAJOR_VERSION < 10) { + // Symbol.asyncIterator polyfill for Node 8 + 9 + ;(Symbol as any).asyncIterator = + Symbol.asyncIterator || Symbol('Symbol.asyncIterator') +} const globP = util.promisify(glob) diff --git a/yarn.lock b/yarn.lock index a68c1bd..753e27f 100644 --- a/yarn.lock +++ b/yarn.lock @@ -50,6 +50,11 @@ resolved "https://registry.yarnpkg.com/@types/node/-/node-10.12.18.tgz#1d3ca764718915584fcd9f6344621b7672665c67" integrity sha512-fh+pAqt4xRzPfqA6eh3Z2y6fyZavRIumvjhaCL753+TVkGKGhpPeyrJG2JftD0T9q4GF00KjefsQ+PQNDdWQaQ== +"@types/node@^12.0.7": + version "12.0.7" + resolved "https://registry.yarnpkg.com/@types/node/-/node-12.0.7.tgz#4f2563bad652b2acb1722d7e7aae2b0ff62d192c" + integrity sha512-1YKeT4JitGgE4SOzyB9eMwO0nGVNkNEsm9qlIt1Lqm/tG2QEiSMTD4kS3aO6L+w5SClLVxALmIBESK6Mk5wX0A== + "@types/npm-packlist@^1.1.0": version "1.1.0" resolved "https://registry.yarnpkg.com/@types/npm-packlist/-/npm-packlist-1.1.0.tgz#d14cdb7b1e759680ad54f77fe6fede5e821817d7"