Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Minor correction to the README. The 'close'-event is seemingly called 'end'. #110

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

gausby commented May 17, 2013

Just a minor type miss print in the README.md. Seemingly it will never trigger the 'close'-event, but the 'end'-event works just fine.

Martin Gausby Corrected on('close' ...) to on('end' ...) in the advanced usage example
Just a minor type miss print in the README.md. Seemingly it will never trigger the 'close'-event, but the 'end'-event works just fine.
5111a0a
Owner

wdavidw commented May 20, 2013

The example is correct, the close event is more appropriate because it will wait for the underlying file to close before being thrown. I've just tested, the node samples/sample.js with this example run just fine. Could you confirm. Thanks

@wdavidw wdavidw closed this May 20, 2013

gausby commented May 20, 2013

Sorry, I was a bit tired when I filed the issue. In my use-case I skip the .to.path()-step, and that is, as far as I understand after reading a bit, the reason why close isn't called, and I need to use end as it is triggered when the data has been passed.

The project in question is here: https://github.com/gausby/ecoute-source-csv

Node-csv-parser is awesome. Keep up the good work and thanks for making it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment