One 16-bit unicode character can expand to up to four UTF-8 8-bit characters. #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…racters. Signed-off-by: Hans Petter Selasky <hps@selasky.org>
wdoekes
reviewed
Apr 16, 2021
| @@ -403,7 +403,7 @@ EXPORT_DEF int at_parse_cmgr(char *str, size_t len, int *tpdu_type, char *sca, s | |||
| /* tpdu_parse_deliver sets chan_dongle_err */ | |||
| return -1; | |||
| } | |||
| res = ucs2_to_utf8(msg16_tmp, res, msg, res * 2 + 2); | |||
| res = ucs2_to_utf8(msg16_tmp, res, msg, res * 4 + 2); | |||
There was a problem hiding this comment.
I don't know why there was "+ 2". The "res * 4" already makes some assumptions about the buffer being passed is large enough. It doesn't hurt to have some extra space though ...
There was a problem hiding this comment.
It doesn't hurt to have some extra space though ...
Extra space for a single NUL, if you're unsure: sure. But two extra spaces? That hurts, because it implies that that space is used for something.
The X*2+2 calculation looks like you're converting from 1-octet to 2-octet chars keeping room for a 2-octet NUL, so that made sense, even though it was wrong here. But I cannot think of a logical reason to do X*4+2.
|
Closed by #131. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue receiving SMS.
Signed-off-by: Hans Petter Selasky hps@selasky.org