New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solaron/Solarized Light scheme for IDE X #11

Closed
landy2005 opened this Issue Dec 25, 2016 · 21 comments

Comments

Projects
None yet
4 participants
@landy2005
Copy link

landy2005 commented Dec 25, 2016

Hi,

this is not issue, but request / offer for make Solaron/Solarized Light fully compatible with Komodo 10.
Currently as I see only Interface/widgets need to be added to scheme file(s).

In Komodo 10 completely abandoned all Light schemes, and I see you make great work with adopt this schemes for Komodo.

@we3geeks

This comment has been minimized.

Copy link
Owner

we3geeks commented Dec 31, 2016

@landy2005 This has been on my own to-do list for a couple of months now; I will take this on.

@we3geeks

This comment has been minimized.

Copy link
Owner

we3geeks commented Jan 9, 2017

@landy2005 See 27662f6

It is a first version of Solaron-Light with UI support for Komodo v10; there are a couple of areas that I am not completely happy with, but it is complete enough that I would like some feedback if you are open to using it for a bit.

komodo-solaron-light-20170109-a

@we3geeks we3geeks self-assigned this Jan 9, 2017

@Defman21

This comment has been minimized.

Copy link

Defman21 commented Jan 9, 2017

Looks good! :)

@landy2005

This comment has been minimized.

Copy link

landy2005 commented Jan 12, 2017

@we3geeks wohoo, initially very nice!

which troubles I see:

  • in ui drop-down lists merges with background
    solaron-l-b1
  • code minimap is still dark
    solaron-l-b2

tnx for your work!

@Defman21

This comment has been minimized.

Copy link

Defman21 commented Jan 12, 2017

There's no way to change the color of the visible part of your code in the sidebar: it depends on text selection color.

@we3geeks

This comment has been minimized.

Copy link
Owner

we3geeks commented Jan 14, 2017

@landy2005 Thanks for the feedback! Let me see what I can do regarding the background color on the controls on the preferences dialog. Looking at some of the other color schemes (both light and dark), I agree that those would benefit from a bit of contrast there.

@we3geeks

This comment has been minimized.

Copy link
Owner

we3geeks commented Jan 14, 2017

Thoughts?

solaron-light-20170114-a

@landy2005

This comment has been minimized.

Copy link

landy2005 commented Jan 15, 2017

Thoughts?

exactly what is necessary :)

@we3geeks

This comment has been minimized.

Copy link
Owner

we3geeks commented Jan 15, 2017

Thanks. I will get an updated version of the scheme committed later today.

@Defman21

This comment has been minimized.

Copy link

Defman21 commented Jan 20, 2017

Nathan pointed to me that your scheme does not have background for inputs.

image

@we3geeks

This comment has been minimized.

Copy link
Owner

we3geeks commented Jan 20, 2017

Is there a reason the inputs on the dialog you are showing are different than these?

preferences

There is a background color specified which is a different color.

@Defman21

This comment has been minimized.

Copy link

Defman21 commented Jan 20, 2017

@Naatan

This comment has been minimized.

Copy link

Naatan commented Jan 20, 2017

Should be fine as far as the standard Komodo skinning is concerned.

@we3geeks

This comment has been minimized.

Copy link
Owner

we3geeks commented Jan 20, 2017

I'm a little confused...

@Defman21 Is it possible your screenshot was from a version before commit 8d38e23 ?

@Defman21

This comment has been minimized.

Copy link

Defman21 commented Jan 20, 2017

Nope, since I can see the fix for #12 in my Komodo :)

@Naatan

This comment has been minimized.

Copy link

Naatan commented Jan 20, 2017

I just installed the ksf from this repo and I cannot reproduce your issue @Defman21.

@Defman21

This comment has been minimized.

Copy link

Defman21 commented Jan 20, 2017

Hmm...

@Defman21

This comment has been minimized.

Copy link

Defman21 commented Jan 20, 2017

Yeah you're right. I've downloaded Solaron again and it works fine. Sorry for false report :)

@we3geeks

This comment has been minimized.

Copy link
Owner

we3geeks commented Jan 20, 2017

No worries. I've seen occasional situations in Komodo as I've been working on getting the UI stuff into these schemes where I have to exit/restart Komodo and/or apply a different scheme and then go back to the one I'm working on in order to get all the bits and bobs to be applied, but I've not really been able to do it reliably enough to log an issue. I wonder if you got caught in one of those.

Glad someone is looking at it. :)

@Naatan

This comment has been minimized.

Copy link

Naatan commented Jan 20, 2017

@we3geeks you might want to submit these to the Komodo Packages section, then people should get update notifications. Not to mention more people will actually be able to reap the benefits of your work :)

Instructions:

http://community.komodoide.com/packages/submit-instructions/#pane-packages

@we3geeks

This comment has been minimized.

Copy link
Owner

we3geeks commented Jan 20, 2017

@Naatan I do plan to add them there (at least the Solaron and Base16r schemes; not sure about the Minimal schemes) after I have the UI portions of the schemes addressed. I'm actually glad @landy2005 and @Defman21 pinged me: I needed a poke to get moving in that direction.

@we3geeks we3geeks closed this Jan 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment