New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added inflate method in BaseScreenView that does not take context as … #29

Merged
merged 5 commits into from May 1, 2017

Conversation

Projects
None yet
2 participants
@theyann
Contributor

theyann commented Apr 26, 2017

…parameter

I have mental issues and my OCD sometimes takes the best of me. In this case, this wrapper inflate method will simply use the getContext(), so that the view code will be even simpler and clean :)

theyann added some commits Apr 26, 2017

Added inflate method in BaseScreenView that does not take context as …
…parameter

I have mental issues and my OCD sometimes takes the best of me. In this case, this wrapper inflate method will simply use the getContext(), so that the view code will be even simpler and clean :)
another missing import
changing things directly within github is not a good idea! Sorry about this
@theyann

This comment has been minimized.

Show comment
Hide comment
@theyann

theyann Apr 27, 2017

Contributor

This is the last time I do a PR directly from GitHub ... I don't handle imports very well without my trusty IDE ;)

Contributor

theyann commented Apr 27, 2017

This is the last time I do a PR directly from GitHub ... I don't handle imports very well without my trusty IDE ;)

new inflate method now only takes one parameter
the root ViewGroup is now inferred to this

@fabiendevos fabiendevos merged commit a526eef into wealthfront:master May 1, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@fabiendevos

This comment has been minimized.

Show comment
Hide comment
@fabiendevos

fabiendevos May 1, 2017

Contributor

Thanks @theyann !!!

Contributor

fabiendevos commented May 1, 2017

Thanks @theyann !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment