Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added topic arn to queue_message metadata #49

Merged
merged 3 commits into from Nov 7, 2019

Conversation

@artemlitch
Copy link
Contributor

artemlitch commented Nov 6, 2019

Why

We have a queue that handles several different topics that then in our code branch to separate handlers. I would like to utilize the message metadata that we already have and expose the topic_arn to our queue handlers in our micro-services so we can detect which message we are consuming and act accordingly.

What changed

@artemlitch artemlitch requested a review from wealthsimple/developer-tools as a code owner Nov 6, 2019
@artemlitch artemlitch force-pushed the add_topic_to_metadata branch from fffd437 to 326a16d Nov 6, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 6, 2019

Pull Request Test Coverage Report for Build 1217

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 1093: 0.0%
Covered Lines: 206
Relevant Lines: 206

💛 - Coveralls
@6
6 approved these changes Nov 7, 2019
Copy link
Member

6 left a comment

LGTM! 👍

@artemlitch artemlitch merged commit bbfbfac into master Nov 7, 2019
6 checks passed
6 checks passed
ci/circleci: checkout_and_bundle Your tests passed on CircleCI!
Details
ci/circleci: checkout_and_bundle_2_4_5 Your tests passed on CircleCI!
Details
ci/circleci: lint_check Your tests passed on CircleCI!
Details
ci/circleci: rspec Your tests passed on CircleCI!
Details
ci/circleci: vulnerability_check Your tests passed on CircleCI!
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
@artemlitch artemlitch deleted the add_topic_to_metadata branch Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.