Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renames to Simbol with big refactor #2

Merged
merged 10 commits into from May 31, 2018

Conversation

@AlbertoElias
Copy link
Collaborator

commented May 31, 2018

Major refactor that:

  • Renames the library to Simbol
  • Moves to Classes
  • Separates everything into components and uses an event based system for components to communicate with each other. Events and Promises are how developers receive information from Simbol
  • Added error handling
  • Added Simbol support, starting with the base Node class, and a Text class
  • Updates and adds tests

AlbertoElias added some commits Feb 22, 2018

Refactors to use JS Classes and updates tests accordingly.
Struggled to mock Class constructors imported using JS Modules, so tests are not 100% isolated
Refactor that separates the different components
It introduces an event based communication system between components, and also for Holonet users to interact with it.
Adds basic Elements support including Node and Text
Fixes voice support in multiVP
Adds and fixes tests
Fixes interactions
Adds missing comments

@AlbertoElias AlbertoElias changed the title Renames to Simbol Renames to Simbol with big refactor May 31, 2018

@AlbertoElias AlbertoElias merged commit 8a66e40 into master May 31, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@AlbertoElias AlbertoElias deleted the dali branch May 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.