Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix circular imports #89

Merged
merged 1 commit into from Sep 6, 2018

Conversation

Projects
None yet
2 participants
@abadger
Copy link
Collaborator

abadger commented Sep 6, 2018

Circular imports were preventing twiggy from working when it was installed in non-development mode.

@abadger abadger force-pushed the abadger:avoid-circular-imports branch from 0c94ee7 to 09cb386 Sep 6, 2018

@abadger

This comment has been minimized.

Copy link
Collaborator Author

abadger commented Sep 6, 2018

This should test fine once #90 is merged,

@abadger abadger force-pushed the abadger:avoid-circular-imports branch from 09cb386 to 9b548aa Sep 6, 2018

@abadger

This comment has been minimized.

Copy link
Collaborator Author

abadger commented Sep 6, 2018

@wearpants Does this look good to you? I'm not sure why running from the checkout works but installing master python3 setup.py install --user ; python3 -c 'import twiggy ; print(twiggy.__file__)' seems to fail without this change so it seems pretty major.

@wearpants

This comment has been minimized.

Copy link
Owner

wearpants commented Sep 6, 2018

@wearpants

This comment has been minimized.

Copy link
Owner

wearpants commented Sep 6, 2018

This is much nicer anyway.

@wearpants wearpants merged commit d4c5b57 into wearpants:master Sep 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.