New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ordering ns :require #95

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@rodnaph
Copy link

rodnaph commented Apr 14, 2017

Hey - I've added the ability to do a basic sort on ns :require lists. This is my first time contributing to this library, and first time using rewrite-clj so it's pretty rough, I could use some feedback - thanks.

@rodnaph rodnaph force-pushed the rodnaph:order-ns-require branch from 007f596 to 3fa7007 Apr 14, 2017

@weavejester

This comment has been minimized.

Copy link
Owner

weavejester commented Aug 1, 2017

Hi, sorry for getting back to you so late. The notification for this PR seems to have passed me by. Can you add a test for ordering when the requires are on their own lines? We want to make sure it doesn't mess up any line breaks. Can you also change the commit message to:

Add ordering of ns requires
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment