New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when environment defaults are not strings #43

Closed
DanBurton opened this Issue Dec 18, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@DanBurton

DanBurton commented Dec 18, 2015

It seems fishy to me that one can set

:env {:port 5000}

And that this is loaded as the number 5000, but if one's environment variables override this with (for example) PORT=5001 lein run, then :port will be set to the string "5001". This can lead to subtle bugs.

It makes more sense to me to only allow string values in the environment map. Or at least, to log a warning when non-string environment default values are loaded.

@weavejester

This comment has been minimized.

Owner

weavejester commented Dec 18, 2015

This issue is already covered by #36.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment