Exploded wars #48

Closed
wants to merge 1 commit into from

3 participants

@diegs

Hi James,

I have added a :war-explode key to the options for lein-ring. If true, the output of lein ring war and lein ring uberwar will be output to a directory, analogous to mvn war:exploded.

I decided to retain the usage of JarOutputStream for minimal fuss while assembling the jar. To keep things clean and atomic I shifted the task to first build the jar in a temporary location and then ether copy or unzip it to the final location depending on the value of :war-explode.

Please let me know what you think, and thanks for all of your amazing work.

Diego

@weavejester
Owner

Sorry it's taken me so long to get around to reviewing this. Could you squash the "Typo" commit into "Adding documentation", and maybe the "Style" commit could be squashed into "Better handling..."

@diegs

Sorry, not quite up to speed on best practices for pull requests. I rebased everything into a single commit and push --force'd. Please let me know if you'd like me to make any other changes.

@weavejester
Owner

Again, apologies for the lateness of my response. My to-do list has been long of late.

I've taken another look at this, and I think a better solution might be to have an :exploded command line option, rather than a configuration option. Also, the temporary directory thing should be removed, as the target directory already contains intermediate files.

@MichaelBlume
Collaborator

Closing because of lack of activity, please reopen if you'd like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment