Replace contains? on LazySeq with some #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi James, This is an important fix to merge since the current behavior is broken and also throws an exception as of Clojure 1.5.0-beta1: http://dev.clojure.org/jira/browse/CLJ-932 I know you're planning some larger changes for Ring 1.2, but is there any possibility you can wrap up and release this small change in the meantime? |
weavejester
added a commit
that referenced
this pull request
Jan 20, 2013
Replace contains? on LazySeq with some
|
Sorry this took so long to merge. The notification fell through the cracks of my inbox. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contains? now throws an exception when called with a LazySeq. Replace contains? with some to check for dependencies.
This fixes issue #8.