Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix passing of groupbadpix keyword #78

Merged
merged 15 commits into from
Jul 23, 2024
Merged

Fix passing of groupbadpix keyword #78

merged 15 commits into from
Jul 23, 2024

Conversation

weaverba137
Copy link
Owner

This PR closes #77.

A preliminary reading of the original IDL code was not definitive on how the groupbadpix keyword is meant to be used in this example. Some operational testing is needed before merging, but other aspects of this PR should be tested now.

@weaverba137 weaverba137 added the Extra CI Run weekly cron jobs in addition to standard CI suite. label May 16, 2024
@weaverba137 weaverba137 self-assigned this May 16, 2024
@coveralls
Copy link

coveralls commented May 16, 2024

Coverage Status

coverage: 65.976% (-0.3%) from 66.294%
when pulling c33897b on groupbadpix-keyword
into 15d8bbc on main.

@weaverba137 weaverba137 marked this pull request as ready for review June 18, 2024 19:32
@weaverba137
Copy link
Owner Author

This PR now also includes a refactor of djs_median() as well as some changes to the test infrastructure.

@weaverba137 weaverba137 merged commit 26778df into main Jul 23, 2024
22 of 24 checks passed
@weaverba137 weaverba137 deleted the groupbadpix-keyword branch July 23, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Extra CI Run weekly cron jobs in addition to standard CI suite.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bspline.__init__() got an unexpected keyword argument 'groupbadpix'
2 participants