Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Branch: master
Commits on Oct 26, 2010
  1. Fixing an issue with specifying stylesheets with options. Even the te…

    …st was slightly testing the wrong thing.
Commits on Oct 25, 2010
  1. Adding a post-bootstrap event, which is the first time that you can s…

    …afely ask for the theme manager.
Commits on Aug 8, 2010
  1. Removing debug code

  2. Reversing last commit - ill-thought-out - the request is not always s…

    …et (and maybe never set by this point).
  3. Fixing bug where the theme layout information was being applied to no…

    …n-html formats.
    This follows the convention set, I believe, in sfView::initialize(), where if the request's format does not equal "html", the decorator is disabled.
Commits on Aug 4, 2010
  1. Fixing bug so that, if we're in ajax land, we don't set the layout. T…

    …his prevents ajax requests from being decorated.
Commits on Jul 21, 2010
  1. Fixed bad assignment of a variable that was not an array. Caused espe…

    …cially grave problems if no themes are present.
Commits on Jun 27, 2010
Commits on Jun 25, 2010
Commits on May 11, 2010
  1. Fixing bug with actions that forward to other actions of the same theme.

    This was a major bug that was causing my tests to fail, but I thought it was a false-fail caused by special circumstances in the test environment. That was not the case.
    This closes #47
Commits on May 8, 2010
Commits on May 4, 2010
  1. Removing some "null" configuration.

    This had no effect (as was intended), but could prevent other plugins from overriding this value (their value being replaced by the null).
Commits on May 3, 2010
  1. Adding an event on the manager's _addAssets() that allows for asset f…

    …ilenames and options to be rewritten via an event.
    Test is also included.
  2. Fixing bug where if assets were specified using the alternative synta…

    …x (e.g., specifying media, position, etc), they were not removed if the theme changed.
    The next commit will actually contain the test that caught and tests this.
  3. Fixing bug where failing to specify the empty "themes" as an array in…

    … the config had the potential to run over (completely remove) themes from other app.yml file. The result looks like themes being loaded from some app.yml files but not others.
Commits on May 2, 2010
  1. Removing callables example from the app.yml file - I don't like this …

    …feature and I'm not sure if it's necessary.
    The only reason I don't like it is because if you have to change themes during a request (e.g. you were forwarded), then these callables are irreversible. The final theme would end up with the callables having been called from the first theme.
  2. Fixing typo in README.

  3. Adding large functional test for the Controller - to test all of the …

    …different scenarios to see that the correct theme is set.
  4. Fixing two bad variable names and also adding an extra conditional to…

    … handle some problems with the functional tests.
  5. Fixing a few bugs in the controller:

     1) Variable mixup with route matching
     2) The setup allowed for bogus themes to be put into the url, which would then be saved to the session and prevent the default theme from loading. The solution was to pass in an array of allowable themes into the controller method. If the user input is not in the list, it will be ignored.
Something went wrong with that request. Please try again.