Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Error when creating nodegroup with --node-volume-type set to io1 #1006
What you expected to happen?
How to reproduce it?
As you can see, there is a missing parameter "Iops" when using volume type set to io1. Checking the CloudFormation template generated by eksctl, I was able to confirm the following configuration for the NodeGroupLaunchTemplat resource:
Basically eksctl is not setting a value for the "Iops" property when using VolumeType set to "io1". Checking the CloudFormation documentation, you must specify a value for "Iops" when creating io1 volumes.
Anything else we need to know?
Nice find, thanks for creating an issue.
The node group schema doesn't have a field to specify the IOPS and a sensible default can't be chosen here as if you're choosing an
We should add a
I think we should only add a config field and avoid adding a flag that will depend on another flag. So when user sets
We should also make sure we document all of
With regards to default value, I think it'd be fine to pick the maximum, as long as we document it.
Agreed since we have been trying to minimise usage of flags.
I'm not sure I agree with using the maximum value as that'd cost more $ and it also depends on the instance type as documented here: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/EBSVolumeTypes.html#EBSVolumeTypes_piops
This means we'd have to set a default value based on the instance type and maintain a list of such instances that'd get updated over time.
I think we should make that field required and not set a default value.