Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print deprecation message when trying to create an EKS cluster with Kubernetes v1.10 #1049

Closed
marccarre opened this issue Jul 23, 2019 · 2 comments

Comments

@marccarre
Copy link
Member

commented Jul 23, 2019

Why do you want this feature?

When trying to create a cluster with Kubernetes v1.10, from 0.2.0 onwards (post #1026 and #1029), the following is printed:

$ ./eksctl-0.2.0 create cluster --version=1.10
[ℹ]  using region us-west-2
[✖]  invalid version, supported values: 1.11, 1.12, 1.13

This may be confusing for end-users who used to use version 1.10 and may have missed 0.2.0's release notes.

What feature/behavior/change do you want?

We should instead have a message making it explicit that Kubernetes v1.10 was deprecated by EKS, e.g.:

$ ./eksctl-0.2.0 create cluster --version=1.10
[ℹ]  using region us-west-2
[✖]  invalid version, 1.10 is now deprecated ; supported values: 1.11, 1.12, 1.13
see also: https://docs.aws.amazon.com/eks/latest/userguide/kubernetes-versions.html
@rade

This comment has been minimized.

Copy link
Member

commented Jul 23, 2019

I might be missing something here, but... "deprecated" normally means I can still use the feature but am discouraged from doing so and it may stop working at some future point. Whereas here I am no longer able to create 1.10 clusters.

@marccarre

This comment has been minimized.

Copy link
Member Author

commented Jul 23, 2019

Agreed, I'd rather have "is no longer supported". The term "deprecated" was specifically mentioned previously, hence I went for it here and in #1050.

@marccarre marccarre closed this in e106640 Jul 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.