Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to create custom VPC much like KOPS does #279

Closed
nukepuppy opened this issue Oct 23, 2018 · 3 comments · Fixed by #286

Comments

@nukepuppy
Copy link

commented Oct 23, 2018

Why do you want this feature?
It would be wise to use one and not many (other tools) to provision an EKS cluster. While using a tool like kops / terraform one can define things such as the CIDR block.

Ability to set the CIDR block to custom range, and define the subnet CIDR ranges would allow for organizations with pre-existing IP space to provision appropriate CIDRs for VPCs which can then be peered.

What feature/behavior/change do you want?
EKSctl to allow settings a --vpc-cidr and then subnet-cidrs

There is another issue here: #42 where I pointed out this issue and seemed that it should of be a "new issue"

values from something like kops look like

  networkCIDR: 172.31.0.0/16
...
  subnets:
  - cidr: 172.31.80.0/20
    id: subnet-5cae7172
    name: us-east-1a
    type: Public
    zone: us-east-1a
  - cidr: 172.31.16.0/20
    id: subnet-e9b2d3a3
    name: us-east-1b
    type: Public
    zone: us-east-1b
@errordeveloper

This comment has been minimized.

Copy link
Member

commented Oct 23, 2018

As discuss on slack, we'd be happy to provide more configuration options, but it'd be easier to do after we have proper Cluster API support (0.3.0). Until then the things that can be done easily enough would be the following:

  • --vpc-cidr global CIDR that will be subdivided as eksctl sees fit for the required number of AZs
  • per-nodegroup control of public/private routing (after #257)

@errordeveloper errordeveloper self-assigned this Oct 23, 2018

@errordeveloper errordeveloper referenced this issue Oct 24, 2018
2 of 2 tasks complete
@rainmanh

This comment has been minimized.

Copy link

commented Oct 26, 2018

I would be also interested on re-using VPC/Subnets I got instead of letting the tool to create all the resources.
On some scenarios we need to re-use Network infrastructure instead of creating it. Sometimes we are limited and We cannot create it new.

@errordeveloper

This comment has been minimized.

Copy link
Member

commented Oct 26, 2018

@rainmanh there is a general issue that is still open (#42), but we have already added support for re-using a VPC where kops cluster resides (which is mostly for migration and cluster peering use-cases). We are getting close to being able to cater for fixing #42 also.

@errordeveloper errordeveloper referenced this issue Oct 26, 2018
3 of 4 tasks complete
errordeveloper added a commit that referenced this issue Oct 26, 2018
Merge pull request #286 from weaveworks/vpc-cidr
 Add `--vpc-cidr` flag

- close #158
- close #279
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.