nodegroup stack builder should not assume subnet/AZ mapping based on the order #293
At the moment we assume order of subnets we get in a list is the same as the order of AZs. This is indeed the case most of the time with
I believe we have to options here:
Broadly, the boundary is currently unclean between how we use stack exports and how we maintain state on eksctl side, we have a bit of mix going on at the moment and it's most likely to stay that way, as we do what's convenient most of the time, especially because some of CloudFormation facilities are harder to use then others and we only utilise some of them.
This area needs to be reviewed.
The code is here:
This is arguably okay for most of current uses actually, this is not called in isolation from cluster stack creation process. Calling the API actually will require mocking in tests. I maybe easier to export list of zone, as it's probably safe to assume CloudFormation won't re-order the list in any way.
However, there is a nodegroup stack part, that currently depends on