Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Enable use of existing subnets #305
2 times, most recently
Nov 6, 2018
Yeah, but I based on #306 there is still plenty of opportunities in this particular area. Per my comment above, there is a bug that needs to be addressed, and looks like I will have to address #293 along the way also. This is fairly trivial, but it does imply we might have to add mocks for a few somewhat incidental EC2 API calls. Having said that, maybe a good idea to go with a follow-up PR rather then jamming everything into this one.…
On Wed, 7 Nov 2018, 9:15 am Richard Case, ***@***.***> wrote: ***@***.**** approved this pull request. This looks good to be. I wonder if we need to think about refactoring (in general) in the future to start reducing the size of functions to make it cleaner and less complex. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#305 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAPWS-oqJIL8OXWwJkp0LBxPnKniXs4Aks5usqTIgaJpZM4YQwCl> .