Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to override node bootstrap script #522

Merged
merged 2 commits into from Feb 8, 2019

Conversation

@errordeveloper
Copy link
Member

commented Feb 7, 2019

Description

This should close #69. It introduces a way for user to override the entier bootstrap.{al2,ubuntu}.sh with their own version.

Checklist

  • Code compiles correctly (i.e make build)
  • Added tests that cover your change (if possible)
  • All unit tests passing (i.e. make test)
  • All integration tests passing (i.e. make integration-test)

@errordeveloper errordeveloper force-pushed the fix-69 branch 2 times, most recently from 4fbfa95 to e13ef8c Feb 7, 2019

@errordeveloper errordeveloper changed the title WIP: custom bootstrap script Allow user to override node bootstrap script Feb 7, 2019

@errordeveloper errordeveloper requested a review from jrryjcksn Feb 7, 2019

pkg/cfn/builder/api_test.go Outdated Show resolved Hide resolved
pkg/cfn/builder/api_test.go Outdated Show resolved Hide resolved
@jrryjcksn
Copy link
Contributor

left a comment

👍

@errordeveloper errordeveloper force-pushed the fix-69 branch 2 times, most recently from 2e2d085 to a18d4d4 Feb 8, 2019

Add a way for users to provide bootstrap command
This should allow those who _know what their are doing_ to pass
a custom script to run inside of cloud-init. Anyone looking to
use this will need to defined a shell script that would resemble
`bootstrap.{al2,ubuntu}.sh`. This should cater for any of advanced
use-cases, where additional files must be created on EC2 instances
prior to boot or anything of that nature. Alternative approach is
to use a custom AMI, or propose an eksctl feature, but this is
meant as a stop-gap for testing things out.
@errordeveloper

This comment has been minimized.

Copy link
Member Author

commented Feb 8, 2019

@jrryjcksn would you mind to re-approve this please?

@jrryjcksn
Copy link
Contributor

left a comment

Looks much better

@errordeveloper errordeveloper merged commit 1838e5f into master Feb 8, 2019

2 checks passed

WIP Ready for review
Details
ci/circleci: make-eksctl-image Your tests passed on CircleCI!
Details

@errordeveloper errordeveloper deleted the fix-69 branch Feb 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.