Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow node-role.kubernetes.io domain prefix in node labeling #582

Merged
merged 1 commit into from Feb 26, 2019

Conversation

@paulbsch
Copy link
Contributor

commented Feb 26, 2019

Solution for issue #580

Description

Very simple change to allow node-role.kubernetes.io domain prefix in node labeling.

Checklist

  • Code compiles correctly (i.e make build)
@errordeveloper
Copy link
Member

left a comment

Thanks @paulbsch! LGMT :)

@errordeveloper errordeveloper merged commit b54bc67 into weaveworks:master Feb 26, 2019

2 checks passed

WIP Ready for review
Details
ci/circleci: make-eksctl-image Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.