Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable allow-ssh flag when a key is specified #657

Merged
merged 2 commits into from Mar 27, 2019

Conversation

@martina-if
Copy link
Member

commented Mar 22, 2019

Description

Checklist

  • Code compiles correctly (i.e make build)
  • Added tests that cover your change (if possible)
  • All unit tests passing (i.e. make test)

@martina-if martina-if force-pushed the martina-if:autoenable-allow-ssh-flag branch from 39a0f1a to c39c902 Mar 22, 2019

@martina-if martina-if force-pushed the martina-if:autoenable-allow-ssh-flag branch from c39c902 to 050d3bb Mar 27, 2019

@martina-if martina-if marked this pull request as ready for review Mar 27, 2019

@errordeveloper
Copy link
Member

left a comment

thanks! 🍰

@martina-if martina-if merged commit 90e1e79 into weaveworks:master Mar 27, 2019

2 checks passed

WIP Ready for review
Details
ci/circleci: make-eksctl-image Your tests passed on CircleCI!
Details
if utils.NodeGroupName(ng.Name, nameArg) == "" {
return cmdutils.ErrNameFlagAndArg(ng.Name, nameArg)
}
ng.Name = utils.NodeGroupName(ng.Name, nameArg)

This comment has been minimized.

Copy link
@errordeveloper

errordeveloper Mar 27, 2019

Member

I missed this... the behaviour here is different from the other version, we will need to reinstate it somehow.

This comment has been minimized.

Copy link
@martina-if

martina-if Mar 28, 2019

Author Member

Maybe I messed up in the rebase, but initially, I did the renaming of the ng.Name with the nameArg when it was provided. I can fix that

This comment has been minimized.

Copy link
@errordeveloper

errordeveloper Mar 28, 2019

Member

No to worry, I have a fix for this in #671.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.