Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to add IAM policies for AWS ALB Ingress Controller #675

Merged
merged 1 commit into from Mar 28, 2019

Conversation

@mcfedr
Copy link
Contributor

commented Mar 28, 2019

Description

The AWS ALB Ingress Controller is a very useful part of any EKS stack, and so it would be very nice to be able to add its required policies automatically along with the others eksctl can add

Checklist

  • Code compiles correctly (i.e make build)
  • Added tests that cover your change (if possible)
  • All unit tests passing (i.e. make test)
  • All integration tests passing (i.e. make integration-test)
  • Added/modified documentation as required (such as the README.md, and examples directory)
  • Added yourself to the humans.txt file

@christopherhein christopherhein self-requested a review Mar 28, 2019

@christopherhein
Copy link
Collaborator

left a comment

LGTM 👍 pending tests passing.

@errordeveloper

@errordeveloper

This comment has been minimized.

Copy link
Member

commented Mar 28, 2019

Thanks, this was a long awaited one!

@christopherhein

This comment has been minimized.

Copy link
Collaborator

commented Mar 28, 2019

@M00nF1sh can you take a look at this as well?

@mcfedr mcfedr referenced this pull request Mar 28, 2019
@M00nF1sh

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2019

/lgtm

@errordeveloper

This comment has been minimized.

Copy link
Member

commented Mar 28, 2019

xref #53

@errordeveloper errordeveloper merged commit fdca204 into weaveworks:master Mar 28, 2019

2 checks passed

WIP Ready for review
Details
ci/circleci: make-eksctl-image Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.