Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support other ssh options #713

Merged
merged 11 commits into from Apr 26, 2019

Conversation

@martina-if
Copy link
Member

commented Apr 8, 2019

closes #386
Support different ways to use SSH keys: by local file, by the key content and through the name of a key already imported in EC2

Checklist

  • rebase
  • Added tests that cover your change (if possible)
  • All unit tests passing (i.e. make test)
  • Manually tested
  • Added/modified documentation as required (such as the README.md, and examples directory)

@martina-if martina-if force-pushed the martina-if:support-other-ssh-options branch 2 times, most recently from c50cb95 to 44d82dd Apr 8, 2019

@martina-if martina-if force-pushed the martina-if:support-other-ssh-options branch 2 times, most recently from fc2ff2c to e0c9c3a Apr 9, 2019

@martina-if martina-if changed the title WIP: Support other ssh options Support other ssh options Apr 9, 2019

@martina-if martina-if requested a review from errordeveloper Apr 10, 2019

@martina-if martina-if force-pushed the martina-if:support-other-ssh-options branch from 19a3c55 to 5b143a3 Apr 10, 2019

README.md Show resolved Hide resolved
pkg/ssh/ssh.go Outdated Show resolved Hide resolved
pkg/ssh/ssh.go Outdated Show resolved Hide resolved
pkg/ssh/ssh.go Outdated Show resolved Hide resolved
@errordeveloper
Copy link
Member

left a comment

This looks great! I just added a few comments, mostly cosmetic :)

Looks like plenty of unit tests also 🥇

@martina-if martina-if force-pushed the martina-if:support-other-ssh-options branch 2 times, most recently from d152561 to 3a692be Apr 23, 2019

@martina-if martina-if force-pushed the martina-if:support-other-ssh-options branch from 3a692be to fd6c771 Apr 26, 2019

@martina-if martina-if requested a review from errordeveloper Apr 26, 2019

pkg/ssh/ssh.go Outdated Show resolved Hide resolved
pkg/utils/file.go Outdated Show resolved Hide resolved

@martina-if martina-if force-pushed the martina-if:support-other-ssh-options branch from 48dd71e to 4da506e Apr 26, 2019

pkg/utils/file.go Outdated Show resolved Hide resolved
pkg/utils/file.go Outdated Show resolved Hide resolved

@martina-if martina-if force-pushed the martina-if:support-other-ssh-options branch from 9b2762f to 1d93016 Apr 26, 2019

@martina-if martina-if requested a review from errordeveloper Apr 26, 2019

@errordeveloper
Copy link
Member

left a comment

🚀🎉

@martina-if martina-if merged commit 30c3a2c into weaveworks:master Apr 26, 2019

2 checks passed

WIP Ready for review
Details
ci/circleci: make-eksctl-image Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.