Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AWS X-Ray Support #805

Merged
merged 13 commits into from May 30, 2019

Conversation

@PaulMaddox
Copy link
Contributor

commented May 20, 2019

This change adds an --xray-access CLI flag, that when specified will
add an IAM policy to the node group IAM role. The IAM policy allows
outbound write access to AWS X-Ray.

The specific policy generated allows access to:

xray:PutTraceSegments
xray:PutTelemetryRecords
xray:GetSamplingRules
xray:GetSamplingTargets
xray:GetSamplingStatisticSummaries

This is useful, as AWS App Mesh (supported with --appmesh-access flag)
can optionally push metrics into AWS X-Ray. For an example of this see
the screenshots here.

I have not updated the README, as it doesn't seem to mention every --*-access type flag today (for example the appmesh flag isn't mentioned).

Also see PaulMaddox/aws-appmesh-helm#1

Description

Checklist

  • Code compiles correctly (i.e make build)
  • Added tests that cover your change (if possible)
  • All unit tests passing (i.e. make test)
  • All integration tests passing (i.e. make integration-test)
  • Added/modified documentation as required (such as the README.md, and examples directory)
  • Added yourself to the humans.txt file
PaulMaddox added 3 commits May 20, 2019
Added AWS X-Ray Support
This change adds an `--xray-access` CLI flag, that when specified will
add an IAM policy to the node group IAM role. The IAM policy allows
outbound write access to AWS X-Ray.

The specific policy allows access to:
```
xray:PutTraceSegments
xray:PutTelemetryRecords
xray:GetSamplingRules
xray:GetSamplingTargets
xray:GetSamplingStatisticSummaries
```

This is useful, as AWS App Mesh (supported with `--appmesh-access` flag)
can optionally push metrics into AWS X-Ray. For an example of this see
the screenshots [here](https://github.com/PaulMaddox/aws-appmesh-helm).

Also see PaulMaddox/aws-appmesh-helm#1
@mumoshu
Copy link
Collaborator

left a comment

@PaulMaddox Thanks a lot for your contribution!

Code LGTM. But I think eksctl is generally moving forward with declarative configuration. That said, it will be even nicer if the new flag is removed for now.

@errordeveloper
Copy link
Member

left a comment

LGTM overall, but let's avoid adding a new flag unless there is a very strong reason to have it?

@PaulMaddox

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

No strong reason - was just copying the previous PR for adding App Mesh, and all of the other IAM options had CLI flags for them. I'll remove the CLI flag.

Tyil and others added 9 commits May 21, 2019
Describe bash3 completion workaround for macOS
Expands the help text for `eksctl completion bash --help` to include the
workaround for bash3 which is commonly found on macOSes.
Fix setup instructions to include dep dependency
Was trying to do a build of the project to test out a currently open PR, and didn't have a preexisting Go setup on my machine.  Looks like you need dep installed to do the `make install-build-deps` step?  

Adding a bit to the documentation to save someone else time in the future
@errordeveloper
Copy link
Member

left a comment

Thanks!

@errordeveloper errordeveloper merged commit b12238d into weaveworks:master May 30, 2019

2 checks passed

WIP Ready for review
Details
ci/circleci: make-eksctl-image Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.