Run signal listener in a goroutine instead of deferring. #1680
Conversation
|
The existing code is probably ported from fluxd, where it is deferred so that it can appear in the context of setting up the shutdown machinery, but run last -- the idea is to grant the various other goroutines, told to shut down by closing the channel, a chance to gracefully do so before exiting. The reason is doesn't work in helm-operator is that the last thing to happen in Since |
|
@captncraig Are you interested in finishing up the PR following @squaremo 's advice? |
|
Sorry, I got sidetracked and lost my dev environment on this one. It would be best if someone else finish this up, or just close it. My bad. |
No worries -- spotting the problem and suggesting a plausible solution gets us most of the way there, so thank you 👍 |
The general scheme in main.go is to start a bunch of goroutines, giving them a shutdown channel; then wait until there's a reason to exit, close the shutdown channel, and wait until the goroutines exit. This wasn't working, because the last stanza in main.go was _not_ run in a goroutine. This commit fixes that, and moves the graceful shutdown bit to the end, for clarity.
|
Thanks @2opremio 🍍 |
Fixes #1679