This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Let fluxctl list-images adhere to namespace filter
#1763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...to maintain backwards compatibility for partial resource IDs (e.g. `deployment/foo`) without running into server side errors due to supplying multiple filters (which the API does not support).
hiddeco
force-pushed
the
837-fluxctl-list-images-ns
branch
from
3c955b0
to
43be571
Compare
squaremo
approved these changes
Feb 26, 2019
There was a problem hiding this comment.
Nice and tidy 🍎
I tried this locally and it worked as I expected:
- asking for
fluxctl list-images --namespace ..shows all the workloads in the namespace - asking for
fluxctl list-images --namespace .. --controller ..uses the namespace to qualify the controller name
The change is backward-compatible to our tacit standard, which is that people are expected to use newer fluxctl with newer fluxd. At worst, if a daemon doesn't understand the namespace parameter, it'll return too many results.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #837.
Tested the daemon with previous
fluxctlversions and saw no abnormalities.