Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: images for other architectures #23

Closed
anguslees opened this issue Jul 21, 2018 · 13 comments · Fixed by #496
Closed

Request: images for other architectures #23

anguslees opened this issue Jul 21, 2018 · 13 comments · Fixed by #496
Milestone

Comments

@anguslees
Copy link

Feature request: Please provide images for other architectures (more than amd64) as part of your release.

kured needs to run on every node, and for my cluster that means amd64, arm, and arm64. I can build those myself, but it would be better if other similar users could also benefit from some centralised effort to support other archs. Thanks :)

@anguslees
Copy link
Author

If it helps, I have some cross-building (arm) Dockerfiles in https://github.com/anguslees/kured-docker - autobuilt images are at quay.io/anguslees/kured-{amd64,arm}.

Note the Dockerfiles are based on alpine, including a dbus-send replacement for systemctl reboot

@jmreicha
Copy link

@anguslees I just opened #56 if you're interested.

@github-actions
Copy link

This issue was automatically considered stale due to lack of activity. Please update it and/or join our slack channels to promote it, before it automatically closes (in 7 days).

@dholbach dholbach added the build label Nov 27, 2020
@dholbach dholbach linked a pull request Nov 27, 2020 that will close this issue
@github-actions github-actions bot closed this as completed Dec 5, 2020
@paulfantom
Copy link

Since #56 was closed I implemented a simple GH workflow for building multi-arch images in https://github.com/paulfantom/dockerfiles/blob/master/.github/workflows/kured.yml with images available at quay.io/paulfantom/kured. Maybe someone will find it useful to implement a similar workflow in this repository.

Sorry for pinging on the closed issue.

@evrardjp
Copy link
Collaborator

Don't be sorry! It proves interest.

Do you think you could provide a PR to update our workflows with this kind of content?

@evrardjp evrardjp reopened this Dec 14, 2020
@paulfantom
Copy link

Right now I don't have the capacity to tackle this.

@github-actions
Copy link

This issue was automatically considered stale due to lack of activity. Please update it and/or join our slack channels to promote it, before it automatically closes (in 7 days).

@anthr76
Copy link

anthr76 commented May 31, 2021

Should this be re-opened?

@anthr76
Copy link

anthr76 commented Jun 2, 2021

Are PRs welcome?

@dholbach
Copy link
Member

dholbach commented Jun 2, 2021

yes, very much so - Jonathan McCracken wanted to take a look at this as well, if memory serves...

@evrardjp
Copy link
Collaborator

Yes, any help is welcomed.

@dholbach dholbach added help wanted keep This won't be closed by the stale bot. labels Jul 28, 2021
@kingdonb
Copy link
Contributor

kingdonb commented Aug 7, 2021

I am using the kured image from quay.io/paulfantom/kured @ 1.7.0 and it works great, my cluster is a multiarch with Raspberry Pi CM3+ running as arm architecture (32 bit), and an amd64 machine. @anthr76 If you want to take a stab at the PR, I would be happy to review it here. (If you don't get around to it, I will come back and figure it out myself eventually.)

Here is the kustomization.yaml that I used to install on my cluster:

https://bitbucket.org/kingdonb/csh-flux/src/main/infrastructure/kured/kustomization.yaml

@davideshay
Copy link
Contributor

@dholbach , @evrardjp , I have added pull request #496 that should handle this. It supports amd64 and arm64 -- i didn't have any straight arm hardware to test, but it should work just by adding "arm" to the platforms list.

@ckotzbauer ckotzbauer linked a pull request Apr 2, 2022 that will close this issue
@ckotzbauer ckotzbauer added this to the 1.10.0 milestone Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants