Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break out Volumes in new topology #3547

Open
satyamz opened this issue Jan 8, 2019 · 6 comments
Open

Break out Volumes in new topology #3547

satyamz opened this issue Jan 8, 2019 · 6 comments
Labels
feature Indicates that issue is related to new end user functionality k8s Pertains to integration with Kubernetes

Comments

@satyamz
Copy link
Contributor

satyamz commented Jan 8, 2019

What you expected to happen?

Currently, pods view is cluttered when storage filter is applied. It would be great idea to separate the Storage view and form a new topology called Volumes below hosts. (Why below hosts? Because, if we put it below the Services then topology header will consume more space)
Whenever, As amount of volumes i.e. PVCs in cluster increases then it becomes difficult to look at graphical view in Scope.

image

PS: Ignore the Pools from the above picture.

@fbarl
Copy link
Contributor

fbarl commented May 22, 2019

Sounds like a step forward to me, with one comment to make.

Why below hosts? Because, if we put it below the Services then topology header will consume more space

I agree with not putting it below Services, but given that the idea is that topologies within a column should be correlated somehow, I don't think we should put it under Hosts.. How about dedicating a special column to it? Perhaps it would already make sense to start thinking about separate Storage topologies which could all go under one column.. That would also correspond with how K8s docs have it organized:

image

cc @bia

@fbarl fbarl added feature Indicates that issue is related to new end user functionality k8s Pertains to integration with Kubernetes labels May 22, 2019
@satyamz
Copy link
Contributor Author

satyamz commented May 22, 2019

Good thought @fbarl, with a right attestation. I would let you, @bia and team decide on the UX front 😄
Once this is decided, we can move ahead.

@bia
Copy link
Contributor

bia commented May 27, 2019

@fbarl and I agree that this could be a good time to reorganize the placement of all topologies in the context of scope becoming more docker+k8s focused.

I opened #3625 which will give us a bit more clarity and screen space to work with, while we still need to learn more about which topologies should hierarchically fit in a column with others.

@satyamz
Copy link
Contributor Author

satyamz commented May 29, 2019

Sure @bia ! I will wait for the final decision from both of you. Thanks for looking into this.

@bia
Copy link
Contributor

bia commented Jun 11, 2019

Today @satyamz and I talked about incorporating the work from #3625 to sort all topologies the way that they are organised in k8s docs :
190611scope-grouping-1

This unfortunately feels like too many columns and the sorting dropdowns feel a little confusing.

Here, with the sorting options that @fbarl mentioned.
190613scope-grouping-1

@fbarl
Copy link
Contributor

fbarl commented Jun 13, 2019

This unfortunately feels like too many columns

Before we figure a more proper solution there, I would suggest:

  1. Keeping Services in the same column as Controllers and Pods for now - I think Services don't really require a special column before we start differentiating between different types
  2. Maybe we could put Processes in the row with Containers? Now that they are both dropdowns, we get an extra dimension there

Two more remarks:

  1. Weave Net topology also can appear there, right now under Hosts - I think it's good to keep it that way for now
  2. In case we go with extending the storage type topologies, I think it'd be easy to group them all under a Storage dropdown later on 👍

sorting dropdowns feel a little confusing

I think they look fine :) The only thing we discussed but I don't see the screenshot is the subtext for the selected option from a dropdown (so in the case above, I guess it should be something like no grouping just under the selected Containers topology).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Indicates that issue is related to new end user functionality k8s Pertains to integration with Kubernetes
Projects
None yet
Development

No branches or pull requests

3 participants