Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition weave-scope Helm chart into this repository? #3807

Open
dholbach opened this issue Jul 2, 2020 · 20 comments
Open

Transition weave-scope Helm chart into this repository? #3807

dholbach opened this issue Jul 2, 2020 · 20 comments
Labels
dogfood Important for the developer's own use of the project estimate/hours It will take less than 8 hours to implement help-wanted An issue that would be good for non-maintainers to attempt

Comments

@dholbach
Copy link
Contributor

dholbach commented Jul 2, 2020

https://github.com/helm/charts/tree/master/stable/weave-scope will be retired Aug 18 and it might make sense to transition the chart over into this repository to keep it all in one place and potentially attract contributors here as well?

kured has almost completed the process in kubereboot/kured#140 and

kured was very lucky to have @ckotzbauer and @davidkarlsen who helped out with the process.

Maybe it'd be possible to invite some of the folks in https://github.com/helm/charts/commits/master/stable/weave-scope and https://github.com/helm/charts/issues?q=weave-scope+is%3Aopen+ to help out?

@dholbach dholbach added dogfood Important for the developer's own use of the project estimate/hours It will take less than 8 hours to implement help-wanted An issue that would be good for non-maintainers to attempt labels Jul 3, 2020
@dholbach
Copy link
Contributor Author

Meeting is happening next week 28th July: https://docs.google.com/document/d/103_60TuEkfkhz_h2krrPJH8QOx-vRnPpbcCZqrddE1s/edit# - please join to discuss it there.

@dholbach
Copy link
Contributor Author

I reached out to the authors who contributed to the chart and we have a couple of offers of help.

The way we set this up with kured (if we want to follow the same model) is

  • two Github Actions that are triggered whenever a release is tagged
  • in Initial Kured Helm-Chart kubereboot/kured#150 we copied the chart as is in the first commit, then applied a number of changes to make the chart more compliant with current standards, resolved a couple of inconsistencies, then added the GH actions
  • if memory serves, we only needed to set up an empty gh-pages branch and enable Github pages - that was all
  • it needed a couple more commits to get it all working fine, but it wasn't too much work

Does anyone want to set up an initial PR for this?

Scope maintainers (@qiell @bboreham @fbarl @satyamz): Any opinions on how to move forward?

@dholbach
Copy link
Contributor Author

https://github.com/helm/charts/issues/21103 will need an update too.

@davidkarlsen
Copy link

I've updated the issue in helm-charts.

@scottrigby
Copy link

Thanks for this!

Could you use help pulling in the chart commit history or setting up the Helm GH Actions? See this git repo for an up to date reference https://github.com/helm/charts-repo-actions-demo

I mentioned chart commit history only because this has proven useful elsewhere. It may even be worth bringing back the chart history for kured. For an example on doing this retroactively, see this issue goharbor/harbor-helm#48 I also don't mind helping with a PR, it would just take a little coordination.

One more thought. An idiomatic way to manage an org's charts is a separate git repo holding the source code for multiple charts. The benefit here is simplifying setup for chart CI (testing/releasing) in only one place whenever updates are needed. I'd be happy to setup an example of this so you can see it using the above history splicing on all the weave charts, if that would be helpful (if so, please ping in k8s slack #charts channel in case I miss a reply here).

@dholbach
Copy link
Contributor Author

Thanks @scottrigby for adding more detail to the discussion - we talked about this in the kured meetings and decided we'd like to have the source available in the same repository to focus everyone's attention on the same code. Not sure how the Scope maintainers feel about this.

Losing commit history in kured is a fair point. We could file an issue for that in kured and see if we can easily bring it back.

Thanks also for your offer of help!

@scottrigby
Copy link

@dholbach I can see that too - keeping chart with app source is also legit 👍 Re help, any time 😄

@dholbach
Copy link
Contributor Author

@cpanato @daixiang0 @ckotzbauer and @davidkarlsen all offered help too.

Does anyone want to take the lead and we discuss in the Scope meeting (28th July) ... or any time on Slack?

@daixiang0
Copy link

@dholbach hi, i would to like to do it, let us talk at Slack.

@ckotzbauer
Copy link

@dholbach I can join the meeting on 28th.

@scottrigby
Copy link

Hey gang, just following up to see if anything new came out of the scope meeting?

@dholbach
Copy link
Contributor Author

So the helm chart upstream is being retired today. Does anyone have time today (or soon) to take a look at this?

@scottrigby
Copy link

@dholbach To be clear, the stable repo will still be operational until Nov 13, just de-listed soon from Helm Hub (and Artifact Hub. See helm/helm#8626). That means new users browsing the Hubs (or with helm search hub command) won't see the chart listed until it's moved to a new helm repo and registered with the hubs. Buys a little more time, but still good to prioritize 😸

@dholbach
Copy link
Contributor Author

This has happened now: helm/charts#24414

@Xtigyro
Copy link

Xtigyro commented Nov 25, 2020

Yup - deprecated in the helm/charts repo. Any progress here?

@bashims
Copy link

bashims commented Jan 22, 2021

Any news on the transition? Thanks.

@debu99
Copy link

debu99 commented May 17, 2021

where is the new helm chart repo?

@dholbach
Copy link
Contributor Author

Unfortunately the transition hasn't happened yet. Help would be appreciated.

@dholbach
Copy link
Contributor Author

https://github.com/squillace/kube-scope-weave depends on the chart as well.

@ifelsefi
Copy link

ifelsefi commented Feb 16, 2022

This would be great to see since we would want to run behind nginx reverse proxy with ldap or oauth authentication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dogfood Important for the developer's own use of the project estimate/hours It will take less than 8 hours to implement help-wanted An issue that would be good for non-maintainers to attempt
Projects
None yet
Development

No branches or pull requests

9 participants