Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote jsonpath so shell doesn't try to expand #1651

Merged
merged 1 commit into from Jul 6, 2016

Conversation

Projects
None yet
2 participants
@rothgar
Copy link
Contributor

commented Jul 6, 2016

This fixes #1526 I realized it was a problem with zsh trying to expand items..metadata. Single quotes fixes it for zsh and also works in bash

example in zsh

$ echo {items..metadata}
. a d e i m s t
$ echo '{items..metadata}'
{items..metadata}
@tomwilkie

This comment has been minimized.

Copy link
Contributor

commented Jul 6, 2016

Build failure is due to this being a PR from a non-weaveworks branch. We should fix that, but its unrelated.

LGTM

@tomwilkie tomwilkie merged commit d65a656 into weaveworks:master Jul 6, 2016

1 check failed

ci/circleci Your tests failed on CircleCI
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.