From 38ff835f524e43a8f64b8d8ca1f7224dc340bc42 Mon Sep 17 00:00:00 2001 From: rokshana-b Date: Tue, 11 Jan 2022 10:46:42 -0500 Subject: [PATCH 1/5] remove checkpoint for tests --- .github/actions/run-acceptance-test/action.yml | 1 + .github/workflows/deploy.yml | 1 + .github/workflows/nightly.yaml | 2 ++ 3 files changed, 4 insertions(+) diff --git a/.github/actions/run-acceptance-test/action.yml b/.github/actions/run-acceptance-test/action.yml index a80f93d707..3fc2f1fbaa 100644 --- a/.github/actions/run-acceptance-test/action.yml +++ b/.github/actions/run-acceptance-test/action.yml @@ -112,6 +112,7 @@ runs: if [ "${{ github.job }}" == "smoke-tests-long" ]; then export GIT_PROVIDER="${{ inputs.git-provider }}" fi + export CHECKPOINT_DISABLE=1 ginkgo ${{ inputs.focus-or-skip }} --randomizeSuites --reportFile=${{ env.ARTIFACTS_BASE_DIR }}/${{ inputs.result-prefix }}acceptance-test-results.xml -v ./test/acceptance/test/... if: always() - name: Store acceptance test results diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index 779d460e10..9a1a72bceb 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -153,6 +153,7 @@ jobs: export WEGO_BIN_PATH=$(pwd)/bin/gitops go get github.com/onsi/ginkgo/ginkgo go get github.com/onsi/gomega + export CHECKPOINT_DISABLE=1 ginkgo --randomizeSuites --reportFile=${{ env. ARTIFACTS_BASE_DIR }}/test-results/acceptance-test-results.xml -v ./test/acceptance/test/... - name: Store acceptance-tests results uses: actions/upload-artifact@v2 diff --git a/.github/workflows/nightly.yaml b/.github/workflows/nightly.yaml index ec1f491f4d..271bc3fa76 100644 --- a/.github/workflows/nightly.yaml +++ b/.github/workflows/nightly.yaml @@ -138,6 +138,7 @@ jobs: $WEGO_BIN_PATH flux uninstall --silent $WEGO_BIN_PATH flux uninstall --namespace test-namespace --silent kubectl get all --all-namespaces -o wide + export CHECKPOINT_DISABLE=1 ginkgo --reportFile=${{ env.ARTIFACTS_BASE_DIR }}/test-results/acceptance-test-results.xml --skip=@skipOnNightly -v ./test/acceptance/test/... if: always() - name: Store acceptance test results @@ -258,6 +259,7 @@ jobs: $WEGO_BIN_PATH flux uninstall --silent $WEGO_BIN_PATH flux uninstall --namespace test-namespace --silent kubectl get all --all-namespaces -o wide + export CHECKPOINT_DISABLE=1 ginkgo --reportFile=${{ env.ARTIFACTS_BASE_DIR }}/test-results/acceptance-test-results.xml --skip=@skipOnNightly -v ./test/acceptance/test/... if: always() - name: Store acceptance test results From 57b4cae70b75bf40ec3607559d8c68ffbb2a0094 Mon Sep 17 00:00:00 2001 From: rokshana-b Date: Tue, 11 Jan 2022 14:53:19 -0500 Subject: [PATCH 2/5] add checkpoint env --- .github/workflows/deploy.yml | 3 ++- .github/workflows/nightly.yaml | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index 9a1a72bceb..608bc1183d 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -41,6 +41,7 @@ jobs: env: GITHUB_TOKEN: "${{ secrets.WEAVE_GITOPS_TEST_WEAVEWORKS_WEAVE_GITOPS_BOT_TOKEN }}" KUBEBUILDER_ASSETS: ${{ github.workspace }}/kubebuilder/bin + CHECKPOINT_DISABLE: 1 runs-on: ubuntu-latest steps: - name: Install Go @@ -91,6 +92,7 @@ jobs: GITLAB_TOKEN: ${{ secrets.GITLAB_TOKEN }} GITLAB_KEY: ${{ secrets.GITLAB_KEY }} ARTIFACTS_BASE_DIR: "/tmp/gitops-test" + CHECKPOINT_DISABLE: 1 steps: - name: Install Go uses: actions/setup-go@v2 @@ -153,7 +155,6 @@ jobs: export WEGO_BIN_PATH=$(pwd)/bin/gitops go get github.com/onsi/ginkgo/ginkgo go get github.com/onsi/gomega - export CHECKPOINT_DISABLE=1 ginkgo --randomizeSuites --reportFile=${{ env. ARTIFACTS_BASE_DIR }}/test-results/acceptance-test-results.xml -v ./test/acceptance/test/... - name: Store acceptance-tests results uses: actions/upload-artifact@v2 diff --git a/.github/workflows/nightly.yaml b/.github/workflows/nightly.yaml index 271bc3fa76..a5d85fc5f1 100644 --- a/.github/workflows/nightly.yaml +++ b/.github/workflows/nightly.yaml @@ -44,6 +44,7 @@ jobs: GITLAB_TOKEN: ${{ secrets.GITLAB_TOKEN }} GITLAB_KEY: ${{ secrets.GITLAB_KEY }} ARTIFACTS_BASE_DIR: "/tmp/gitops-test" + CHECKPOINT_DISABLE: 1 steps: - name: Install Go uses: actions/setup-go@v2 @@ -138,7 +139,6 @@ jobs: $WEGO_BIN_PATH flux uninstall --silent $WEGO_BIN_PATH flux uninstall --namespace test-namespace --silent kubectl get all --all-namespaces -o wide - export CHECKPOINT_DISABLE=1 ginkgo --reportFile=${{ env.ARTIFACTS_BASE_DIR }}/test-results/acceptance-test-results.xml --skip=@skipOnNightly -v ./test/acceptance/test/... if: always() - name: Store acceptance test results @@ -166,6 +166,7 @@ jobs: GITLAB_TOKEN: ${{ secrets.GITLAB_TOKEN }} GITLAB_KEY: ${{ secrets.GITLAB_KEY }} ARTIFACTS_BASE_DIR: "/tmp/gitops-test" + CHECKPOINT_DISABLE: 1 steps: - name: Install Go uses: actions/setup-go@v2 @@ -259,7 +260,6 @@ jobs: $WEGO_BIN_PATH flux uninstall --silent $WEGO_BIN_PATH flux uninstall --namespace test-namespace --silent kubectl get all --all-namespaces -o wide - export CHECKPOINT_DISABLE=1 ginkgo --reportFile=${{ env.ARTIFACTS_BASE_DIR }}/test-results/acceptance-test-results.xml --skip=@skipOnNightly -v ./test/acceptance/test/... if: always() - name: Store acceptance test results From c1c5f5d24d87fcb28726f5cd2329d831dd4679fe Mon Sep 17 00:00:00 2001 From: rokshana-b Date: Tue, 11 Jan 2022 14:57:15 -0500 Subject: [PATCH 3/5] add checkpoint env for pr tests --- .github/actions/run-acceptance-test/action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/actions/run-acceptance-test/action.yml b/.github/actions/run-acceptance-test/action.yml index 3fc2f1fbaa..843502f9e3 100644 --- a/.github/actions/run-acceptance-test/action.yml +++ b/.github/actions/run-acceptance-test/action.yml @@ -103,6 +103,7 @@ runs: GITLAB_TOKEN: ${{ inputs.gitlab-token }} GITLAB_KEY: ${{ inputs.gitlab-key }} ARTIFACTS_BASE_DIR: ${{ inputs.artifacts-base-dir }} + CHECKPOINT_DISABLE: 1 run: | export PATH=${PATH}:`go env GOPATH`/bin export WEGO_BIN_PATH=$(pwd)/bin/gitops @@ -112,7 +113,6 @@ runs: if [ "${{ github.job }}" == "smoke-tests-long" ]; then export GIT_PROVIDER="${{ inputs.git-provider }}" fi - export CHECKPOINT_DISABLE=1 ginkgo ${{ inputs.focus-or-skip }} --randomizeSuites --reportFile=${{ env.ARTIFACTS_BASE_DIR }}/${{ inputs.result-prefix }}acceptance-test-results.xml -v ./test/acceptance/test/... if: always() - name: Store acceptance test results From a7614b9e74edb1083ce08757ff72eeae0022f39f Mon Sep 17 00:00:00 2001 From: rokshana-b Date: Tue, 11 Jan 2022 16:51:48 -0500 Subject: [PATCH 4/5] update readme --- test/acceptance/README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/acceptance/README.md b/test/acceptance/README.md index 318c3f1960..520c7fc41a 100644 --- a/test/acceptance/README.md +++ b/test/acceptance/README.md @@ -34,6 +34,8 @@ To run github tests on gitlab repos, export the following variable before runnin export GIT_PROVIDER=gitlab ``` +When adding tests that require creating **multiple clusters**, please add a `@skipOnNightly` tag to the test in order to prevent Nightly Test failures. Our Nightly Tests run on standing clusters (EKS, GKE), and this test setup does not support creating multiple clusters on the fly. + # Smoke Tests To run the **smoke tests** from the suite, run the following the command from the repo root directory. From 91a1c73411cce8cb575fe862b0cb64e7dddb25d9 Mon Sep 17 00:00:00 2001 From: rokshana-b Date: Tue, 11 Jan 2022 16:55:25 -0500 Subject: [PATCH 5/5] fix readme --- test/acceptance/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/acceptance/README.md b/test/acceptance/README.md index 520c7fc41a..7bf06da944 100644 --- a/test/acceptance/README.md +++ b/test/acceptance/README.md @@ -34,7 +34,7 @@ To run github tests on gitlab repos, export the following variable before runnin export GIT_PROVIDER=gitlab ``` -When adding tests that require creating **multiple clusters**, please add a `@skipOnNightly` tag to the test in order to prevent Nightly Test failures. Our Nightly Tests run on standing clusters (EKS, GKE), and this test setup does not support creating multiple clusters on the fly. +To add tests that require the creation of **multiple clusters**, please add a `@skipOnNightly` tag to the test in order to prevent Nightly Test failures. Our Nightly Tests run on standing clusters (EKS, GKE), and this test setup does not support creating multiple clusters on the fly. # Smoke Tests