#2790: enable adding annotations to the weave-gitops deployment #2791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2790
Changes the Helm chart that deploys the UI by adding a new entry in the
values.yamlfile.annotations: It adds annotations (if any) to the weave-gitops deployment.Why was this change made?
I need to add certain annotations to make github.com/stakater/reloader reload the deployment on configuration/credentials rotation.
How was this change implemented?
Just added a new non-required (optional) element to the values.yaml file.
How did you validate the change?
Rendering testing with multiple values in there.
Release notes
Documentation Changes