Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release script added to create release/release candidates #844

Merged
merged 4 commits into from
Oct 7, 2021

Conversation

J-Thompson12
Copy link
Contributor

Closes: #638

What changed?
Adds a script to tag/create releases and release candidates

Why?

How did you test it?
Manually on a fork.

Release notes

Documentation Changes
In the PR

# 1) Fetch the current release version

echo "Fetch tags"
git fetch --prune origin +refs/tags/*:refs/tags/*
Copy link
Contributor Author

@J-Thompson12 J-Thompson12 Oct 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ended up changing this line from the original because I noticed that --prune was not working if I had deleted tags in github.

@jpellizzari
Copy link

Gonna test this out in a fork when I get a chance. It might take me a bit to review.

Copy link

@jpellizzari jpellizzari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@J-Thompson12 I get this error on my machine (Ubuntu with a regular terminal):

$ ./tools/tag-release.sh -p

Fetch tags
Current version: 0.3.0
./tools/tag-release.sh: line 115: unexpected EOF while looking for matching `"'
./tools/tag-release.sh: line 117: syntax error: unexpected end of file

Let me know if you can reproduce

tools/tag-release.sh Outdated Show resolved Hide resolved
@J-Thompson12
Copy link
Contributor Author

@J-Thompson12 I get this error on my machine (Ubuntu with a regular terminal):

$ ./tools/tag-release.sh -p

Fetch tags
Current version: 0.3.0
./tools/tag-release.sh: line 115: unexpected EOF while looking for matching `"'
./tools/tag-release.sh: line 117: syntax error: unexpected end of file

Let me know if you can reproduce

@jpellizzari I was able to reproduce the error. It was caused by the extra ". Not sure how I put that in there. It wasnt in the forked version i was testing on. Its gone now and working.

Copy link

@jpellizzari jpellizzari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "promotion" flow is excellent. Nice work. The release jobs are failing on my fork, but I think that is to be expected.


if [ ! -z $release ]
then
if [[ $version == *"rc"* ]]; then # If the last version was not a release candidate then exit

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Really clever work on this part. I love the "promotion" UX. Very simple and elegant.

Justin Thompson and others added 3 commits October 7, 2021 13:47
remove extra "

Co-authored-by: Jordan Pellizzari <jordan@weave.works>
…endencies (#854)

* Fix spurious regex DoS vulnerability

* Only scan production node modules for vulnerabilities

* Turn auditing back on
@J-Thompson12 J-Thompson12 merged commit 4e14a36 into main Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a script to tag releases
2 participants