This repository has been archived by the owner on Mar 31, 2023. It is now read-only.
Enable non-GCP integration tests #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Corrects some formatting - Adds back supporting local-docker-registry tooling - Corrects some paths
foot
force-pushed
the
56-enable-integration-tests
branch
from
2411cff
to
6e671bb
Compare
- Tackle in another PR
foot
force-pushed
the
56-enable-integration-tests
branch
from
49f457f
to
b0d166e
Compare
foot
approved these changes
Sep 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the non-GCP part of #56.
To move forward with the GCP integration tests, @foot or @fbarl probably need permissions to move across the
SECRET_KEYenv var in CircleCI.