Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent IndexNullState and IndexPropertyLength to be updated #2368

Merged
merged 1 commit into from Nov 18, 2022

Conversation

dirkkul
Copy link
Contributor

@dirkkul dirkkul commented Nov 16, 2022

What's being changed:

closes #2360

IndexNullState and IndexPropertyLength could be updated for an existing schema. This would create problems as existing objects are not reindexed

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:

@dirkkul dirkkul changed the base branch from master to stable/v1.16 November 16, 2022 14:06
@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Base: 68.04% // Head: 68.06% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (e1e37ef) compared to base (68c3022).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff                @@
##           stable/v1.16    #2368      +/-   ##
================================================
+ Coverage         68.04%   68.06%   +0.01%     
================================================
  Files               530      530              
  Lines             53348    53360      +12     
================================================
+ Hits              36299    36317      +18     
+ Misses            14814    14810       -4     
+ Partials           2235     2233       -2     
Flag Coverage Δ
integration 68.74% <100.00%> (+0.04%) ⬆️
unittests 53.35% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
adapters/handlers/rest/embedded_spec.go 100.00% <100.00%> (ø)
adapters/repos/db/inverted/config_update.go 100.00% <100.00%> (ø)
adapters/repos/db/lsmkv/bucket.go 63.84% <0.00%> (-2.06%) ⬇️
usecases/sharding/state.go 66.40% <0.00%> (+0.80%) ⬆️
adapters/repos/db/vector/hnsw/index.go 58.44% <0.00%> (+0.86%) ⬆️
adapters/repos/db/vector/hnsw/delete.go 77.88% <0.00%> (+1.68%) ⬆️
adapters/repos/db/shard_write_batch_objects.go 77.27% <0.00%> (+2.27%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dirkkul dirkkul merged commit 9c8a930 into stable/v1.16 Nov 18, 2022
@dirkkul dirkkul deleted the immutable_ii_props branch November 18, 2022 10:45
trengrj pushed a commit to trengrj/weaviate that referenced this pull request Dec 2, 2022
…props

Prevent IndexNullState and IndexPropertyLength to be updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants